JohnKellyFerguson/octomaps

View on GitHub
public/admin/javascripts/bootstrap/carousel.js

Summary

Maintainability
A
4 hrs
Test Coverage

Function slide has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  Carousel.prototype.slide = function (type, next) {
    var $active   = this.$element.find('.item.active')
    var $next     = next || $active[type]()
    var isCycling = this.interval
    var direction = type == 'next' ? 'left' : 'right'
Severity: Minor
Found in public/admin/javascripts/bootstrap/carousel.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      $(window).on('load', function () {
        $('[data-ride="carousel"]').each(function () {
          var $carousel = $(this)
          $carousel.carousel($carousel.data())
        })
    Severity: Major
    Found in public/admin/javascripts/bootstrap/carousel.js and 1 other location - About 1 hr to fix
    public/admin/javascripts/bootstrap/scrollspy.js on lines 149..154

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

      $.fn.carousel.noConflict = function () {
        $.fn.carousel = old
        return this
      }
    Severity: Major
    Found in public/admin/javascripts/bootstrap/carousel.js and 8 other locations - About 40 mins to fix
    public/admin/javascripts/bootstrap/affix.js on lines 97..100
    public/admin/javascripts/bootstrap/alert.js on lines 85..88
    public/admin/javascripts/bootstrap/button.js on lines 90..93
    public/admin/javascripts/bootstrap/collapse.js on lines 133..136
    public/admin/javascripts/bootstrap/dropdown.js on lines 139..142
    public/admin/javascripts/bootstrap/modal.js on lines 215..218
    public/admin/javascripts/bootstrap/scrollspy.js on lines 140..143
    public/admin/javascripts/bootstrap/tab.js on lines 119..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status