Sign upLogin

KarrLab/wc_lang

View on GitHub
Star
wc_lang/transform/create_implicit_dfba_ex_rxns.py

Summary

Maintainability
B
5 hrs
Test Coverage
A
98%

Function run has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def run(self, model):
        """ Create implicit exchange reactions for dFBA submodels

        Args:
            model (:obj:`Model`): model
Severity: Minor
Found in wc_lang/transform/create_implicit_dfba_ex_rxns.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if species.species_type.structure and species.species_type.structure.has_carbon():
                            flux_bounds = carbon_flux_bounds
                        else:
                            flux_bounds = no_carbon_flux_bounds
Severity: Major
Found in wc_lang/transform/create_implicit_dfba_ex_rxns.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if rxn:
                            assert rxn.submodel == submodel
                            assert rxn.name == name
                            assert rxn.participants == participants
                            assert rxn.reversible == reversible
    Severity: Major
    Found in wc_lang/transform/create_implicit_dfba_ex_rxns.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status