KarrLab/wc_test

View on GitHub

Showing 2 of 7 total issues

Function test_reactions_balanced has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def test_reactions_balanced(self):
        """ Check that each reaction is element and charge balanced

        Raises:
            :obj:`Exception`: if one or more reactions is unbalanced
Severity: Minor
Found in tests.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function select_submodels has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def select_submodels(self, mod_submodels):
        """ Turn off all submodels, except the ones listed in submodel_ids """
        for id, status in mod_submodels.items():
            if not status:
                submodel = self.model.submodels.get_one(id=id)
Severity: Minor
Found in wc_test/core.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language