Kentico/delivery-sdk-php

View on GitHub
src/KenticoCloud/Delivery/DefaultMapper.php

Summary

Maintainability
A
25 mins
Test Coverage

Function getTypeClass has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getTypeClass($typeName)
    {
        switch ($typeName) {
            case 'asset':
                $type = \KenticoCloud\Delivery\Models\Items\Asset::class;
Severity: Minor
Found in src/KenticoCloud/Delivery/DefaultMapper.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused local variables such as '$element'.
Open

            foreach ($data[self::ELEMENTS_ATTRIBUTE_NAME] as $elementName => $element) {

Since: PHPMD 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example:

class Foo {
      public function doSomething()
      {
          $i = 5; // Unused
      }
  }

Source: http://phpmd.org/rules/unusedcode.txt

There are no issues that match your filters.

Category
Status