Kentico/delivery-sdk-php

View on GitHub
src/KenticoCloud/Delivery/ModelBinder.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function bindModel has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function bindModel($modelType, $data, $linkedItems = null, $processedItems = null)
    {
        $processedItems = $processedItems ?? array();
        $model = new $modelType();
        $modelProperties = $this->propertyMapper->getModelProperties($model, $data);
Severity: Minor
Found in src/KenticoCloud/Delivery/ModelBinder.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bindLinkedItems has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function bindLinkedItems($element, $linkedItems, $processedItems)
    {
        $modelLinkedItems = null;
        if ($linkedItems != null) {
            $modelLinkedItems = array();
Severity: Minor
Found in src/KenticoCloud/Delivery/ModelBinder.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bindModel has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function bindModel($modelType, $data, $linkedItems = null, $processedItems = null)
    {
        $processedItems = $processedItems ?? array();
        $model = new $modelType();
        $modelProperties = $this->propertyMapper->getModelProperties($model, $data);
Severity: Minor
Found in src/KenticoCloud/Delivery/ModelBinder.php - About 1 hr to fix

    Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
    Open

        public function bindModel($modelType, $data, $linkedItems = null, $processedItems = null)

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    There are no issues that match your filters.

    Category
    Status