Sign upLogin

Kuangcp/JavaBase

View on GitHub
Star

Showing 339 of 339 total issues

Method main has a Cognitive Complexity of 157 (exceeds 5 allowed). Consider refactoring.
Open

    public static void main(final String[] args) throws UnknownHostException {
        boolean storeFile = false, binaryTransfer = false, error = false, listFiles = false, listNames = false, hidden = false;
        boolean localActive = false, useEpsvWithIPv4 = false, feat = false, printHash = false;
        boolean mlst = false, mlsd = false, mdtm = false, saveUnparseable = false;
        boolean size = false;
Severity: Minor
Found in network/src/main/java/com/github/kuangcp/app/ftp/FTPClientExample.java - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method main has 341 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static void main(final String[] args) throws UnknownHostException {
        boolean storeFile = false, binaryTransfer = false, error = false, listFiles = false, listNames = false, hidden = false;
        boolean localActive = false, useEpsvWithIPv4 = false, feat = false, printHash = false;
        boolean mlst = false, mlsd = false, mdtm = false, saveUnparseable = false;
        boolean size = false;
Severity: Major
Found in network/src/main/java/com/github/kuangcp/app/ftp/FTPClientExample.java - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                case 1:
                switch (me.getDirect()) {//己方 上下左右 分开
                    case 0: {
                        if ((you.getX() - 10 <= me.getX() - 10 &&
                                you.getX() + 10 >= me.getX() - 10 &&
    Severity: Major
    Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java and 1 other location - About 1 day to fix
    gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java on lines 98..162

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 742.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                case 3://对方左右
                switch (me.getDirect()) {//己方 上下左右 分开
                    case 0: {
                        if ((you.getX() - 15 <= me.getX() - 10 &&
                                you.getX() + 15 >= me.getX() - 10 &&
    Severity: Major
    Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java and 1 other location - About 1 day to fix
    gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java on lines 31..95

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 742.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method paint has a Cognitive Complexity of 66 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public void paint(Graphics g) {
        super.paint(g);

        if (PlayStageMgr.stageNoneStart() || Objects.isNull(hero)) {
    Severity: Minor
    Found in gui/src/main/java/com/github/kuangcp/tank/panel/TankGroundPanel.java - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ablePass has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
    Open

        public static boolean ablePass(Tank me, Tank you) {
        if (Objects.isNull(me) || Objects.isNull(you)) {
            return true;
        }
        if (!me.isAlive() || !you.isAlive()) {
    Severity: Minor
    Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method wordAnalysis has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
    Open

        public static List<ExpressionWord> wordAnalysis(String expressionStr) {
        String expStrNoSpace = remove(expressionStr, ' '); //去除目标表达式中的空格字符
        char[] exChar = expStrNoSpace.toCharArray();
        List<ExpressionWord> expressionWord = new ArrayList<>();
        for (int i = 0; i < exChar.length; i++) {
    Severity: Minor
    Found in algorithms/src/main/java/com/github/kuangcp/parser/expression/Expression.java - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public void run() {
        while (hero.isAlive() && !exit) {
            if (eventGroup.hasPressMoveEvent()) {
//                log.info("eventGroup={}", eventGroup);
    Severity: Minor
    Found in gui/src/main/java/com/github/kuangcp/tank/util/HeroKeyListener.java - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method maxList has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
    Open

        public Integer maxList(List<Fraction> list, boolean isMax, boolean haveInfinity, boolean permitMinus) {
        Integer index = null;
        //有非数的集合
        if (haveInfinity) {
            Map<Integer, Fraction> tempMap = new HashMap<>();
    Severity: Minor
    Found in question/src/main/java/com/github/kuangcp/simplex/method/SimplexMethodWithFraction.java - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ablePass has 142 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static boolean ablePass(Tank me, Tank you) {
        if (Objects.isNull(me) || Objects.isNull(you)) {
            return true;
        }
        if (!me.isAlive() || !you.isAlive()) {
    Severity: Major
    Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 5 hrs to fix

      File FTPClientExample.java has 397 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
      Severity: Minor
      Found in network/src/main/java/com/github/kuangcp/app/ftp/FTPClientExample.java - About 5 hrs to fix

        Method paint has 125 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
    public void paint(Graphics g) {
        super.paint(g);

        if (PlayStageMgr.stageNoneStart() || Objects.isNull(hero)) {
        Severity: Major
        Found in gui/src/main/java/com/github/kuangcp/tank/panel/TankGroundPanel.java - About 5 hrs to fix

          Method getScore has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
          Open

              private int getScore(int x, int y) {
        int tempX = x;
        int tempY = y;
        int count = 0;
        int block = 0;
          Severity: Minor
          Found in gui/src/main/java/com/github/kuangcp/gomoku/AI.java - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method wordAnalysis has 114 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static List<ExpressionWord> wordAnalysis(String expressionStr) {
        String expStrNoSpace = remove(expressionStr, ' '); //去除目标表达式中的空格字符
        char[] exChar = expStrNoSpace.toCharArray();
        List<ExpressionWord> expressionWord = new ArrayList<>();
        for (int i = 0; i < exChar.length; i++) {
          Severity: Major
          Found in algorithms/src/main/java/com/github/kuangcp/parser/expression/Expression.java - About 4 hrs to fix

            File Expression.java has 350 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            package com.github.kuangcp.parser.expression;

import java.math.BigDecimal;
import java.util.ArrayList;
import java.util.List;
            Severity: Minor
            Found in algorithms/src/main/java/com/github/kuangcp/parser/expression/Expression.java - About 4 hrs to fix

              Method main has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
              Open

                public static void main(String[] args) {
    for (int k = 0; k < minSize; k++) {
      stack[k] = new Point();
      path[k] = new Point();
    }
              Severity: Minor
              Found in algorithms/src/main/java/com/github/kuangcp/strcuture/stackapp/OutOfTheMaze.java - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method installGCMonitoring has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static void installGCMonitoring(){
        //get all the GarbageCollectorMXBeans - there's one for each heap generation
        //so probably two - the old generation and young generation
        List<GarbageCollectorMXBean> gcbeans = java.lang.management.ManagementFactory.getGarbageCollectorMXBeans();
        //Install a notifcation handler for each bean
              Severity: Minor
              Found in class/src/main/java/jvm/gc/MxBeanCallback.java - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method match has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
              Open

                public void match(String origin) {
    log.info("input string={}", origin);
    initBrackets();

    MythBaseStack<Integer> stack = new MythLinkedStack<>();
              Severity: Minor
              Found in algorithms/src/main/java/com/github/kuangcp/strcuture/stackapp/MatchBracket.java - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getScore has 91 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private int getScore(int x, int y) {
        int tempX = x;
        int tempY = y;
        int count = 0;
        int block = 0;
              Severity: Major
              Found in gui/src/main/java/com/github/kuangcp/gomoku/AI.java - About 3 hrs to fix

                File TankGroundPanel.java has 318 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                package com.github.kuangcp.tank.panel;

import com.github.kuangcp.tank.domain.Brick;
import com.github.kuangcp.tank.domain.Bullet;
import com.github.kuangcp.tank.domain.EnemyTank;
                Severity: Minor
                Found in gui/src/main/java/com/github/kuangcp/tank/panel/TankGroundPanel.java - About 3 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language