Kuangcp/JavaBase

View on GitHub

Showing 221 of 349 total issues

Method run has a Cognitive Complexity of 117 (exceeds 5 allowed). Consider refactoring.
Open

    private void run(final String[] args) throws UnknownHostException {
        int base = parseArgs(args);

        String server = args[base++];
        int port = 0;
Severity: Minor
Found in network/src/main/java/com/github/kuangcp/app/ftp/FTPClientExample.java - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method paint has a Cognitive Complexity of 66 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void paint(Graphics g) {
        super.paint(g);

        if (PlayStageMgr.stageNoneStart() || Objects.isNull(hero)) {
Severity: Minor
Found in gui/src/main/java/com/github/kuangcp/tank/panel/TankGroundPanel.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 227 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void run(final String[] args) throws UnknownHostException {
        int base = parseArgs(args);

        String server = args[base++];
        int port = 0;

    Method ablePass has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
    Open

        public static boolean ablePass(Tank me, Tank you) {
            if (Objects.isNull(me) || Objects.isNull(you)) {
                return true;
            }
            if (!me.isAlive() || !you.isAlive()) {
    Severity: Minor
    Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method wordAnalysis has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
    Open

        public static List<ExpressionWord> wordAnalysis(String expressionStr) {
            String expStrNoSpace = remove(expressionStr, ' '); //去除目标表达式中的空格字符
            char[] exChar = expStrNoSpace.toCharArray();
            List<ExpressionWord> expressionWord = new ArrayList<>();
            for (int i = 0; i < exChar.length; i++) {

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
        public void run() {
            while (hero.isAlive() && !exit) {
                if (eventGroup.hasPressMoveEvent()) {
    //                log.info("eventGroup={}", eventGroup);
    Severity: Minor
    Found in gui/src/main/java/com/github/kuangcp/tank/util/HeroKeyListener.java - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File FTPClientExample.java has 450 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
     * Licensed to the Apache Software Foundation (ASF) under one or more
     * contributor license agreements.  See the NOTICE file distributed with
     * this work for additional information regarding copyright ownership.
     * The ASF licenses this file to You under the Apache License, Version 2.0

      Method maxList has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
      Open

          public Integer maxList(List<Fraction> list, boolean isMax, boolean haveInfinity, boolean permitMinus) {
              Integer index = null;
              //有非数的集合
              if (haveInfinity) {
                  Map<Integer, Fraction> tempMap = new HashMap<>();

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ablePass has 142 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static boolean ablePass(Tank me, Tank you) {
              if (Objects.isNull(me) || Objects.isNull(you)) {
                  return true;
              }
              if (!me.isAlive() || !you.isAlive()) {
      Severity: Major
      Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 5 hrs to fix

        Method paint has 125 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
            public void paint(Graphics g) {
                super.paint(g);
        
                if (PlayStageMgr.stageNoneStart() || Objects.isNull(hero)) {
        Severity: Major
        Found in gui/src/main/java/com/github/kuangcp/tank/panel/TankGroundPanel.java - About 5 hrs to fix

          Method parseArgs has 124 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private int parseArgs(String[] args) throws UnknownHostException {
                  int base;
                  label:
                  for (base = 0; base < args.length; base++) {
                      switch (args[base]) {

            Method getScore has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
            Open

                private int getScore(int x, int y) {
                    int tempX = x;
                    int tempY = y;
                    int count = 0;
                    int block = 0;
            Severity: Minor
            Found in gui/src/main/java/com/github/kuangcp/gomoku/AI.java - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method wordAnalysis has 114 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static List<ExpressionWord> wordAnalysis(String expressionStr) {
                    String expStrNoSpace = remove(expressionStr, ' '); //去除目标表达式中的空格字符
                    char[] exChar = expStrNoSpace.toCharArray();
                    List<ExpressionWord> expressionWord = new ArrayList<>();
                    for (int i = 0; i < exChar.length; i++) {

              File Expression.java has 350 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              package com.github.kuangcp.parser.expression;
              
              import java.math.BigDecimal;
              import java.util.ArrayList;
              import java.util.List;

                Method main has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static void main(String[] args) {
                        for (int k = 0; k < minSize; k++) {
                            stack[k] = new Point();
                            path[k] = new Point();
                        }

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method installGCMonitoring has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static void installGCMonitoring(){
                        //get all the GarbageCollectorMXBeans - there's one for each heap generation
                        //so probably two - the old generation and young generation
                        List<GarbageCollectorMXBean> gcbeans = java.lang.management.ManagementFactory.getGarbageCollectorMXBeans();
                        //Install a notifcation handler for each bean
                Severity: Minor
                Found in class/src/main/java/jvm/gc/MxBeanCallback.java - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method match has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
                Open

                  public void match(String origin) {
                    log.info("input string={}", origin);
                    initBrackets();
                
                    MythBaseStack<Integer> stack = new MythLinkedStack<>();

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getScore has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private int getScore(int x, int y) {
                        int tempX = x;
                        int tempY = y;
                        int count = 0;
                        int block = 0;
                Severity: Major
                Found in gui/src/main/java/com/github/kuangcp/gomoku/AI.java - About 3 hrs to fix

                  File TankGroundPanel.java has 318 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  package com.github.kuangcp.tank.panel;
                  
                  import com.github.kuangcp.tank.domain.Brick;
                  import com.github.kuangcp.tank.domain.Bullet;
                  import com.github.kuangcp.tank.domain.EnemyTank;
                  Severity: Minor
                  Found in gui/src/main/java/com/github/kuangcp/tank/panel/TankGroundPanel.java - About 3 hrs to fix

                    Method ablePass has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static boolean ablePass(Tank t, Hinder h) {
                            int hx = h.getWidth(), hy = h.getHeight();
                            final int halfHeight = t.getHalfHeight();
                            final int halfWidth = t.getHalfWidth();
                    
                    
                    Severity: Minor
                    Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language