Sign upLogin

Kylob/Hierarchy

View on GitHub
Star
src/Component.php

Summary

Maintainability
D
2 days
Test Coverage

File Component.php has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace BootPress\Hierarchy;

use BootPress\Database\Component as Database;
Severity: Minor
Found in src/Component.php - About 2 hrs to fix

    Method tree has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function tree($column, $field = null, $value = null, $having = null)
    {
        $tree = array();
        if (func_num_args() >= 3) {
            $depth = (is_string($having) && strpos($having, 'depth') !== false) ? ' HAVING '.$having : null;
    Severity: Minor
    Found in src/Component.php - About 1 hr to fix

      Function nestify has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function nestify(array $tree)
    {
        $nested = array();
        $children = array();
        foreach ($tree as $id => $fields) {
      Severity: Minor
      Found in src/Component.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method counts has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function counts($table, $match, $id = null)
    {
        if (!is_null($id)) {
            return (int) $this->db->value(array(
                'SELECT COUNT('.$table.'.'.$match.') AS count',
      Severity: Minor
      Found in src/Component.php - About 1 hr to fix

        Function refresh has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function refresh($order = null)
    {
        if (is_null($order)) {
            $order = $this->id;
        }
        Severity: Minor
        Found in src/Component.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function flatten has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function flatten(array $nest, array $related = array())
    {
        $children = array();
        foreach ($nest as $id => $values) {
            $parents = $related;
        Severity: Minor
        Found in src/Component.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function counts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function counts($table, $match, $id = null)
    {
        if (!is_null($id)) {
            return (int) $this->db->value(array(
                'SELECT COUNT('.$table.'.'.$match.') AS count',
        Severity: Minor
        Found in src/Component.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function level($depth, $column)
    {
        $single = (!is_array($column)) ? $column : false;
        $level = array();
        if ($stmt = $this->db->query('SELECT '.$this->id.', '.implode(', ', (array) $column).' FROM '.$this->table.' WHERE level = ? ORDER BY lft', $depth, 'assoc')) {
        Severity: Major
        Found in src/Component.php and 1 other location - About 4 hrs to fix
        src/Component.php on lines 263..275

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 166.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function children($id, $column) // The immediate subordinates of a node ie. no grand children
    {
        $single = (!is_array($column)) ? $column : false;
        $children = array();
        if ($stmt = $this->db->query('SELECT '.$this->id.', '.implode(', ', (array) $column).' FROM '.$this->table.' WHERE parent = ? ORDER BY lft', $id, 'assoc')) {
        Severity: Major
        Found in src/Component.php and 1 other location - About 4 hrs to fix
        src/Component.php on lines 299..311

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 166.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status