Sign upLogin

Kylob/SQLite

View on GitHub
Star
src/Fts.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method search has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function search($table, $search, $limit = '', $where = '', array $fields = array(), array $weights = array())
    {
        if (is_null($this->rank)) {
            $this->rank = $this->db->connection()->createFunction('rank', array(&$this, 'rank'), 2);
        }
Severity: Minor
Found in src/Fts.php - About 1 hr to fix

    Function search has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function search($table, $search, $limit = '', $where = '', array $fields = array(), array $weights = array())
    {
        if (is_null($this->rank)) {
            $this->rank = $this->db->connection()->createFunction('rank', array(&$this, 'rank'), 2);
        }
    Severity: Minor
    Found in src/Fts.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method search has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function search($table, $search, $limit = '', $where = '', array $fields = array(), array $weights = array())
    Severity: Minor
    Found in src/Fts.php - About 45 mins to fix

      Avoid using BootPress\SQLite\count() function in for loops.
      Open

              for ($i = 0; $i < (count($offsets) / 4); ++$i) {
            list($column, $term, $byte, $size) = array_slice($offsets, $i * 4, 4);
            $word = strtolower(substr($search[$column], $byte, $size));
            if ($combine == array($column, $term, $byte)) {
                $word = array_pop($words).' '.$word;
      Severity: Minor
      Found in src/Fts.php by phpmd

      CountInLoopExpression

      Since: 2.7.0

      Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

      Example

      class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

      Source https://phpmd.org/rules/design.html#countinloopexpression

      There are no issues that match your filters.

      Category
      Status