Sign upLogin

Kynetics/uf-android-client

View on GitHub
Star

Showing 23 of 95 total issues

Class CurrentUpdateState has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

// todo refactor
class CurrentUpdateState(context: Context) {

    private val sharedPreferences: SharedPreferences
Severity: Minor
Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/update/CurrentUpdateState.kt - About 3 hrs to fix

    Method install has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        override fun install(
        artifact: Updater.SwModuleWithPath.Artifact,
        currentUpdateState: CurrentUpdateState,
        messenger: Updater.Messenger,
        context: Context
    Severity: Major
    Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/update/system/ABOtaInstaller.kt - About 2 hrs to fix

      File ABOtaInstaller.kt has 268 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
 * Copyright © 2017-2023  Kynetics  LLC
 * 
 * This program and the accompanying materials are made
 * available under the terms of the Eclipse Public License 2.0
      Severity: Minor
      Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/update/system/ABOtaInstaller.kt - About 2 hrs to fix

        Method build has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                fun build(
            configurationHandler: ConfigurationHandler,
            mNotificationManager: NotificationManager,
            service: UpdateFactoryService
        ): AndroidDeploymentPermitProvider {
        Severity: Minor
        Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/configuration/AndroidDeploymentPermitProvider.kt - About 1 hr to fix

          Method installationResult has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private fun installationResult(
        updateStatus: CompletableFuture<Int>,
        messenger: Updater.Messenger,
        artifact: Updater.SwModuleWithPath.Artifact
    ): CurrentUpdateState.InstallationResult {
          Severity: Minor
          Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/update/system/ABOtaInstaller.kt - About 1 hr to fix

            Method applyUpdate has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                override fun applyUpdate(
        modules: Set<Updater.SwModuleWithPath>,
        messenger: Updater.Messenger
    ): Updater.UpdateResult {
        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
            Severity: Minor
            Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/update/application/ApkUpdater.kt - About 1 hr to fix

              Method updatePreference has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private fun updatePreference(preference: Preference?, key: String, sharedPrefs: SharedPreferences) {
        if (preference == null || preference is SwitchPreferenceCompat) {
            return
        }
              Severity: Minor
              Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/ui/fragment/UFPreferenceFragment.kt - About 1 hr to fix

                Method install has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @RequiresApi(Build.VERSION_CODES.LOLLIPOP)
    override fun install(
        artifact: Updater.SwModuleWithPath.Artifact,
        currentUpdateState: CurrentUpdateState,
        messenger: Updater.Messenger,
                Severity: Minor
                Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/update/application/ApkInstaller.kt - About 1 hr to fix

                  Method schedule has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      fun schedule(tag:String,
                 timeWindows: UFServiceConfigurationV2.TimeWindows,
                 action:()->Unit):Status{
        with(ExecutionTime.forCron(HaraCronParser.parse(timeWindows.cronExpression))){
            val now: ZonedDateTime = ZonedDateTime.now()
                  Severity: Minor
                  Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/cron/CronScheduler.kt - About 1 hr to fix

                    Method onReceive has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        override fun onReceive(context: Context, intent: Intent) {
        if (PackageInstallerBRHandler.ACTION_INSTALL_COMPLETE != intent.action) {
            return
        }
                    Severity: Minor
                    Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/update/application/PackageInstallerBroadcastReceiver.kt - About 1 hr to fix

                      Method onStatusUpdate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              override fun onStatusUpdate(status: Int, percent: Float) { // i==status  v==percent
            Log.d(TAG, "status:$status")
            Log.d(TAG, "percent:$percent")
            val currentPhaseProgress = min(percent.toDouble(), 100.0)
            val newPhase = previousState != status
                      Severity: Minor
                      Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/update/system/ABOtaInstaller.kt - About 1 hr to fix

                        Method init has 10 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            override fun init(haraClientData: HaraClientData,
                      directoryForArtifactsProvider: DirectoryForArtifactsProvider,
                      configDataProvider: ConfigDataProvider,
                      softDeploymentPermitProvider: DeploymentPermitProvider,
                      messageListeners: List<MessageListener>,
                        Severity: Major
                        Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/client/UpdateFactoryClientWrapper.kt - About 1 hr to fix

                          Method onCreate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              override fun onCreate() {
        super.onCreate()
        AndroidLoggerAdapter.setLogTag("Update Factory Client")
        if(BuildConfig.DEBUG){
            AndroidLoggerAdapter.setLogLevel(LogLevel.TRACE)
                          Severity: Minor
                          Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/UpdateFactoryService.kt - About 1 hr to fix

                            Method fromJson has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    /**
         * Deserialize a [jsonContent] element into a corresponding object of type [UFServiceMessageV1].
         * @throws [SerializationException] if given input can not be deserialized
         * @throws [IllegalArgumentException] if given input isn't a UFServiceMessageV1 json serialization
         */
                            Severity: Minor
                            Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/v1/UFServiceMessageV1.kt - About 1 hr to fix

                              Method newInstance has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      fun newInstance(
            configurationHandler: ConfigurationHandler,
            restartableClientService: RestartableClientService,
            softDeploymentPermitProvider: AndroidDeploymentPermitProvider
        ) :CommunicationApiStrategy{
                              Severity: Minor
                              Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/communication/CommunicationApiStrategy.kt - About 1 hr to fix

                                Method moveSharedPreferences has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    @Suppress("UNCHECKED_CAST")
    private fun moveSharedPreferences(sp1:SharedPreferences, sp2:SharedPreferences, moveTo:(Map.Entry<String, Any?>) -> Boolean){
        sp2.edit().apply{
            val sp1Editor = sp1.edit()
            sp1.all.filter(moveTo).forEach{ entry ->
                                Severity: Minor
                                Found in uf-client-service/src/main/kotlin/com/kynetics/uf/android/content/UFSharedPreferences.kt - About 1 hr to fix

                                  Method intercept has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      @Throws(IOException::class)
    override fun intercept(chain: Interceptor.Chain): Response {
        val originalRequest = chain.request()
        val builder = originalRequest.newBuilder()
        val isConfigDataRequest = originalRequest.url.toString().endsWith(CONFIG_DATA_ACTION)
                                  Severity: Minor
                                  Found in uf-ddiclient/src/main/java/com/kynetics/uf/ddiclient/UpdateFactoryAuthenticationRequestInterceptor.kt - About 1 hr to fix

                                    Method newUFClient has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                            haraClientData: HaraClientData,
        directoryForArtifactsProvider: DirectoryForArtifactsProvider,
        configDataProvider: ConfigDataProvider,
        deploymentPermitProvider: DeploymentPermitProvider,
        messageListeners: List<MessageListener>,
                                    Severity: Major
                                    Found in uf-ddiclient/src/main/java/com/kynetics/uf/ddiclient/HaraClientFactory.kt - About 1 hr to fix

                                      Method newInstance has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                              haraClientData: HaraClientData,
        directoryForArtifactsProvider: DirectoryForArtifactsProvider,
        configDataProvider: ConfigDataProvider,
        deploymentPermitProvider: DeploymentPermitProvider,
        messageListeners: List<MessageListener>,
                                      Severity: Major
                                      Found in uf-ddiclient/src/main/java/com/kynetics/uf/ddiclient/HaraClientFactory.kt - About 1 hr to fix

                                        Method newHawkbitClient has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                                haraClientData: HaraClientData,
        directoryForArtifactsProvider: DirectoryForArtifactsProvider,
        configDataProvider: ConfigDataProvider,
        deploymentPermitProvider: DeploymentPermitProvider,
        messageListeners: List<MessageListener>,
                                        Severity: Major
                                        Found in uf-ddiclient/src/main/java/com/kynetics/uf/ddiclient/HaraClientFactory.kt - About 50 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language