LTe/acts-as-messageable

View on GitHub

Showing 4 of 4 total issues

Method initialize_scopes has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def initialize_scopes(search_scope)
        scope :are_from, lambda { |*args|
          where(sent_messageable_id: args.first, sent_messageable_type: args.first.class.name)
        }
        scope :are_to, lambda { |*args|
Severity: Minor
Found in lib/acts_as_messageable/scopes.rb - About 1 hr to fix

    Method acts_as_messageable has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def acts_as_messageable(options = {})
            default_options = {
              table_name: 'messages',
              class_name: 'ActsAsMessageable::Message',
              required: %i[topic body],
    Severity: Minor
    Found in lib/acts_as_messageable/model.rb - About 1 hr to fix

      Method delete_message has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def delete_message(message)
              current_user = self
      
              case current_user
              when message.to
      Severity: Minor
      Found in lib/acts_as_messageable/model.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def process(context = relation_context)
            relation = T.cast(self, ActiveRecord::Relation)
      
            relation.each do |message|
              yield(message) if block_given?
      Severity: Minor
      Found in lib/acts_as_messageable/relation.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language