LasLabs/python-helpscout

View on GitHub

Showing 6 of 15 total issues

File conversations.py has 259 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Copyright 2017-TODAY LasLabs Inc.
# License MIT (https://opensource.org/licenses/MIT).

from .. import BaseApi
Severity: Minor
Found in helpscout/apis/conversations.py - About 2 hrs to fix

    Function __new__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __new__(cls, endpoint, data=None,
    Severity: Minor
    Found in helpscout/base_api.py - About 45 mins to fix

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, endpoint, data=None, output_type=dict,
      Severity: Minor
      Found in helpscout/request_paginator/__init__.py - About 35 mins to fix

        Function create has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def create(cls, session, record, endpoint_override=None, out_type=None,
        Severity: Minor
        Found in helpscout/base_api.py - About 35 mins to fix

          Function list has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def list(cls, session, first_name=None, last_name=None, email=None,
          Severity: Minor
          Found in helpscout/apis/customers.py - About 35 mins to fix

            Function _call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def _call(self, method, *args, **kwargs):
                    """Call the remote service and return the response data."""
            
                    assert self.session
            
            
            Severity: Minor
            Found in helpscout/request_paginator/__init__.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language