LaunchPadLab/fuel

View on GitHub

Showing 14 of 14 total issues

File advanced_and_extended.js has 617 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Full HTML5 compatibility rule set
 * Loosened and extended ruleset. Allows more freedom on user side
 * These rules define which tags and CSS classes are supported and which tags should be specially treated.
 */
Severity: Major
Found in app/assets/javascripts/fuel/advanced_and_extended.js - About 1 day to fix

    File to-markdown.js has 558 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.toMarkdown = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
    /*
     * to-markdown - an HTML to Markdown converter
     *
     * Copyright 2011-15, Dom Christie
    Severity: Major
    Found in app/assets/javascripts/fuel/to-markdown.js - About 1 day to fix

      Function 1 has 195 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      (function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.toMarkdown = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
      /*
       * to-markdown - an HTML to Markdown converter
       *
       * Copyright 2011-15, Dom Christie
      Severity: Major
      Found in app/assets/javascripts/fuel/to-markdown.js - About 7 hrs to fix

        Function 3 has 129 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        },{}],3:[function(require,module,exports){
        'use strict';
        
        module.exports = [
          {
        Severity: Major
        Found in app/assets/javascripts/fuel/to-markdown.js - About 5 hrs to fix

          Function 2 has 93 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          },{"./lib/gfm-converters":2,"./lib/md-converters":3,"collapse-whitespace":4,"jsdom":7}],2:[function(require,module,exports){
          'use strict';
          
          function cell(content, node) {
            var index = Array.prototype.indexOf.call(node.parentNode.childNodes, node);
          Severity: Major
          Found in app/assets/javascripts/fuel/to-markdown.js - About 3 hrs to fix

            Function 4 has 73 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            },{}],4:[function(require,module,exports){
            'use strict';
            
            var voidElements = require('void-elements');
            Object.keys(voidElements).forEach(function (name) {
            Severity: Major
            Found in app/assets/javascripts/fuel/to-markdown.js - About 2 hrs to fix

              Function collapseWhitespace has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function collapseWhitespace(elem, isBlock) {
                if (!elem.firstChild || elem.nodeName === 'PRE') return;
              
                if (typeof isBlock !== 'function') {
                  isBlock = isBlockElem;
              Severity: Minor
              Found in app/assets/javascripts/fuel/to-markdown.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if Fuel.configuration.aws_bucket
                      has_attached_file :featured_image, :styles => { :medium => Fuel.configuration.featured_image_settings[:styles][:medium], :thumb => Fuel.configuration.featured_image_settings[:styles][:thumb] }, :default_url => "fuel/default-img.jpg", :storage => :s3, :s3_protocol => :https, :s3_credentials => Proc.new{|a| a.instance.s3_credentials }
                    else
                      has_attached_file :featured_image, :styles => { :medium => Fuel.configuration.featured_image_settings[:styles][:medium], :thumb => Fuel.configuration.featured_image_settings[:styles][:thumb] }, :default_url => "fuel/default-img.jpg"
                    end
                Severity: Major
                Found in app/models/fuel/post.rb and 1 other location - About 1 hr to fix
                app/models/fuel/author.rb on lines 17..21

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 62.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if Fuel.configuration.aws_bucket
                      has_attached_file :avatar, :styles => { :medium => Fuel.configuration.avatar_settings[:styles][:medium], :thumb => Fuel.configuration.avatar_settings[:styles][:thumb] }, :default_url => "fuel/default-img.jpg", :storage => :s3, :s3_protocol => :https, :s3_credentials => Proc.new{|a| a.instance.s3_credentials }
                    else
                      has_attached_file :avatar, :styles => { :medium => Fuel.configuration.avatar_settings[:styles][:medium], :thumb => Fuel.configuration.avatar_settings[:styles][:thumb] }, :default_url => "fuel/default-img.jpg"
                    end
                Severity: Major
                Found in app/models/fuel/author.rb and 1 other location - About 1 hr to fix
                app/models/fuel/post.rb on lines 14..18

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 62.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function 5 has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                },{"block-elements":5,"void-elements":6}],5:[function(require,module,exports){
                /**
                 * This file automatically generated from `build.js`.
                 * Do not manually edit.
                 */
                Severity: Minor
                Found in app/assets/javascripts/fuel/to-markdown.js - About 1 hr to fix

                  Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def initialize
                        @layout = "application"
                        @blog_title = "Blog"
                        @blog_description = "A list of posts about a topic"
                        @disqus_name = nil
                  Severity: Minor
                  Found in lib/fuel/configuration.rb - About 1 hr to fix

                    Avoid deeply nested control flow statements.
                    Open

                            if (prevText) {
                              prevText.data = prevText.data.replace(/ $/, '');
                            }
                    Severity: Major
                    Found in app/assets/javascripts/fuel/to-markdown.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                            } else if (isVoid(node)) {
                              // Avoid trimming space around non-block, non-BR void elements.
                              prevText = null;
                              prevVoid = true;
                            }
                      Severity: Major
                      Found in app/assets/javascripts/fuel/to-markdown.js - About 45 mins to fix

                        Method add_posts_to_db has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                          def add_posts_to_db
                            parsed_json.each do |post|
                              puts "Importing #{post['title']}"
                              post.delete("id")
                              author_first_name = post["author"]["first_name"]
                        Severity: Minor
                        Found in lib/blog_importer.rb - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language