Sign upLogin

Lesterpig/openparty

View on GitHub
Star

Showing 35 of 35 total issues

File controller.js has 422 lines of code (exceeds 250 allowed). Consider refactoring.
Open

angular.module('openparty', [
    'btford.socket-io',
    'ngSanitize',
    'luegg.directives', //for scrollGlue directive
    'ngAudio'
Severity: Minor
Found in public/js/controller.js - About 6 hrs to fix

    Function exports has 152 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(app) {

  /**
   * ROOT
   */
    Severity: Major
    Found in lib/router.js - About 6 hrs to fix

      Function exports has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function(socket) {
  if(!socket.session.identifier) {
    return;
  }
      Severity: Minor
      Found in lib/recover.js - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File audio.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';
angular.module('ngAudio', [])
.directive('ngAudio', ['$compile', '$q', 'ngAudio', function($compile, $q, ngAudio) {
    return {
        restrict: 'AEC',
      Severity: Minor
      Found in public/js/audio.js - About 4 hrs to fix

        File rooms.js has 314 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        var utils   = require('./utils.js');
var players = require('./players.js');
var Player  = players.Player;
        Severity: Minor
        Found in lib/rooms.js - About 3 hrs to fix

          Function setChannel has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

          Player.prototype.setChannel = function(name, rights, silent) {

  if(!rights) {
    if(this.channels[name]) {
      this.leave(name);
          Severity: Minor
          Found in lib/players.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function checkWatchers has 57 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  function checkWatchers() {
            if ($audioWatch) {
                $audioWatch();
            }
            if (audio) {
          Severity: Major
          Found in public/js/audio.js - About 2 hrs to fix

            Function start has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

              start: function(callback) {
    require('./lib/loader.js')(__conf.dataPath, function(err, gametypes) {
      if(err) {
        console.error(err);
        process.exit();
            Severity: Minor
            Found in app.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Room.prototype.resolveUsername = function(username) {
  for(var i = 0; i < this.players.length; i++) {
    if(this.players[i].username === username) {
      return this.players[i];
    }
            Severity: Major
            Found in lib/rooms.js and 1 other location - About 2 hrs to fix
            lib/rooms.js on lines 333..343

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 75.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              getRoom: function(id) {

    for(var i = 0; i < this.rooms.length; i++) {
      if(this.rooms[i].id === id) {
        return this.rooms[i];
            Severity: Major
            Found in lib/rooms.js and 1 other location - About 2 hrs to fix
            lib/rooms.js on lines 267..274

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 75.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function exports has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function(socket) {
  if(!socket.session.identifier) {
    return;
  }
            Severity: Minor
            Found in lib/recover.js - About 1 hr to fix

              Function sendMessage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

              Room.prototype.sendMessage = function(channel, message, socket) {
  var allowed = false;

  if(channel === 'preChat') {
    if(this.started) {
              Severity: Minor
              Found in lib/rooms.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function setRole has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

              Player.prototype.setRole = function(role, value) {
  if(!value && this.roles[role]) {
    // Remove all registered channels
    for(var channel in this.roles[role].channels) {
      if(this.roles[role].channels[channel].r && !this.channels[channel]) {
              Severity: Minor
              Found in lib/players.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getAvailableActions has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

              Player.prototype.getAvailableActions = function(clone) {
  var output = {};

  // role actions
  for(var role in this.roles) {
              Severity: Minor
              Found in lib/players.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function start has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                start: function(callback) {
    require('./lib/loader.js')(__conf.dataPath, function(err, gametypes) {
      if(err) {
        console.error(err);
        process.exit();
              Severity: Minor
              Found in app.js - About 1 hr to fix

                Function leaveRoom has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  leaveRoom: function(socket) {

    var room = socket.currentRoom;
    if(!room) {
      return;
                Severity: Minor
                Found in lib/rooms.js - About 1 hr to fix

                  Function leaveRoom has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                    leaveRoom: function(socket) {

    var room = socket.currentRoom;
    if(!room) {
      return;
                  Severity: Minor
                  Found in lib/rooms.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function exports has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function(basePath, callback) {

  if(!basePath)
    basePath = path.join(__dirname, '..', 'data');
  if(!callback)
                  Severity: Minor
                  Found in lib/loader.js - About 1 hr to fix

                    Function getPublicInfo has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    Room.prototype.getPublicInfo = function() {
  var output = {};

  output.id       = this.id;
  output.isRoom   = true;
                    Severity: Minor
                    Found in lib/rooms.js - About 1 hr to fix

                      Function checkUsername has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                        checkUsername: function(username) {
    if(username.length > 20)
      throw new Error('Username is too long.');

    username = this.sanitizeHtml(username);
                      Severity: Minor
                      Found in lib/utils.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language