LiberTEM/LiberTEM

View on GitHub
src/libertem/io/dataset/base/backend_buffered.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function block_get_min_fill_factor has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

def block_get_min_fill_factor(rrs):
    """
    Try to find out how sparse the given read ranges are, per file.

    Returns the smallest fill factor and maximum required buffer size.
Severity: Minor
Found in src/libertem/io/dataset/base/backend_buffered.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in function block_get_min_fill_factor. (11)
Open

@numba.njit(cache=True, nogil=True)
def block_get_min_fill_factor(rrs):
    """
    Try to find out how sparse the given read ranges are, per file.

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function _read_block_dense has 16 arguments (exceeds 8 allowed). Consider refactoring.
Open

    def _read_block_dense(
Severity: Major
Found in src/libertem/io/dataset/base/backend_buffered.py - About 1 hr to fix

    Function _buffered_tilereader has 11 arguments (exceeds 8 allowed). Consider refactoring.
    Open

        def _buffered_tilereader(outer_idx, buffers, sig_dims, tile_read_ranges,
    Severity: Major
    Found in src/libertem/io/dataset/base/backend_buffered.py - About 50 mins to fix

      Function get_tiles has 9 arguments (exceeds 8 allowed). Consider refactoring.
      Open

          def get_tiles(
      Severity: Major
      Found in src/libertem/io/dataset/base/backend_buffered.py - About 35 mins to fix

        Function readinto has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def readinto(self, buf):
                BLOCKSIZE = self.get_blocksize()
                buf_orig = buf
                buf = memoryview(buf)
                to_read = len(buf)
        Severity: Minor
        Found in src/libertem/io/dataset/base/backend_buffered.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _make_buffered_reader_and_decoder has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def _make_buffered_reader_and_decoder(decode):
            """
            decode: from buffers, in bytes, possibly interpreted as native_dtype, to out_decoded.dtype
            """
            @cached_njit(boundscheck=False, nogil=True)
        Severity: Minor
        Found in src/libertem/io/dataset/base/backend_buffered.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status