Sign upLogin

MBHFramework/structures

View on GitHub
Star

Showing 17 of 17 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for ($k = 1; $k < $count; $k = $k << 1) {
            for ($left = 0; ($left + $k) < $count; $left += $k << 1) {
                $right = $left + $k;
                $rend = min($right + $k, $count);
                $m = $left;
Severity: Major
Found in Mbh/Collection/Traits/Functional/ImmutableSort.php and 1 other location - About 1 day to fix
Mbh/Collection/Traits/Functional/InPlaceSort.php on lines 74..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 294.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for ($k = 1; $k < $count; $k = $k << 1) {
            for ($left = 0; ($left + $k) < $count; $left += $k << 1) {
                $right = $left + $k;
                $rend = min($right + $k, $count);
                $m = $left;
Severity: Major
Found in Mbh/Collection/Traits/Functional/InPlaceSort.php and 1 other location - About 1 day to fix
Mbh/Collection/Traits/Functional/ImmutableSort.php on lines 72..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 294.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Map has 31 functions (exceeds 20 allowed). Consider refactoring.
Open

class Map implements AllocatedInterface, ArrayAccess, CollectionInterface, IteratorAggregate
{
    use Traits\Collection;
    use Traits\Functional;
    use Traits\Builder;
Severity: Minor
Found in Mbh/Collection/Map.php - About 3 hrs to fix

Function mergeSort has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function mergeSort(callable $callback)
    {
        $count = $this->count();
        $result = new SplFixedArray($count);
Severity: Minor
Found in Mbh/Collection/Traits/Functional/InPlaceSort.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mergeSort has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function mergeSort(callable $callback)
    {
        $count = $this->count();
        $sfa = $this->getValues();
Severity: Minor
Found in Mbh/Collection/Traits/Functional/ImmutableSort.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File LinkedList.php has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace Mbh\Collection\Traits\Sequenceable;

use Mbh\Collection\Interfaces\Collection as CollectionInterface;
use Mbh\Collection\Interfaces\Functional as FunctionalInterface;
use Mbh\Collection\Interfaces\Sequenceable as SequenceableInterface;
Severity: Minor
Found in Mbh/Collection/Traits/Sequenceable/LinkedList.php - About 2 hrs to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function join(string $token = ',', string $secondToken = null): string
    {
        $str = "";
        if ($secondToken !== null) {
            foreach ($this as $i => $elem) {
Severity: Major
Found in Mbh/Collection/Traits/ImmutableFunctional.php and 1 other location - About 1 hr to fix
Mbh/Collection/Traits/Functional.php on lines 119..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public function join(string $token = ',', string $secondToken = null): string
    {
        $str = "";
        if ($secondToken !== null) {
            foreach ($this as $i => $elem) {
Severity: Major
Found in Mbh/Collection/Traits/Functional.php and 1 other location - About 1 hr to fix
Mbh/Collection/Traits/ImmutableFunctional.php on lines 117..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method mergeSort has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function mergeSort(callable $callback)
    {
        $count = $this->count();
        $sfa = $this->getValues();
Severity: Minor
Found in Mbh/Collection/Traits/Functional/ImmutableSort.php - About 1 hr to fix

Method mergeSort has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function mergeSort(callable $callback)
    {
        $count = $this->count();
        $result = new SplFixedArray($count);
Severity: Minor
Found in Mbh/Collection/Traits/Functional/InPlaceSort.php - About 1 hr to fix

Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(...$args)
    {
        parent::__construct();

        foreach ($args as $i => $iterator) {
Severity: Minor
Found in Mbh/Iterator/ConcatIterator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function join has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function join(string $token = ',', string $secondToken = null): string
    {
        $str = "";
        if ($secondToken !== null) {
            foreach ($this as $i => $elem) {
Severity: Minor
Found in Mbh/Collection/Traits/ImmutableFunctional.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function join has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function join(string $token = ',', string $secondToken = null): string
    {
        $str = "";
        if ($secondToken !== null) {
            foreach ($this as $i => $elem) {
Severity: Minor
Found in Mbh/Collection/Traits/Functional.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Expected 1 space after FUNCTION keyword; 0 found
Open

        return $this->pairs->map(function($pair) {
Severity: Minor
Found in Mbh/Collection/Map.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

        return $this->pairs->map(function($pair) {
Severity: Minor
Found in Mbh/Collection/Map.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

        return new Set($this->pairs->map(function($pair) {
Severity: Minor
Found in Mbh/Collection/Map.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

                function($item) use ($current) {
Severity: Minor
Found in Mbh/Tree/Traits/Node.php by phpcodesniffer
Severity
Category
Status
Source
Language