Sign upLogin

MBHFramework/structures

View on GitHub
Star

Showing 9 of 17 total issues

Map has 31 functions (exceeds 20 allowed). Consider refactoring.
Open

class Map implements AllocatedInterface, ArrayAccess, CollectionInterface, IteratorAggregate
{
    use Traits\Collection;
    use Traits\Functional;
    use Traits\Builder;
Severity: Minor
Found in Mbh/Collection/Map.php - About 3 hrs to fix

Function mergeSort has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function mergeSort(callable $callback)
    {
        $count = $this->count();
        $result = new SplFixedArray($count);
Severity: Minor
Found in Mbh/Collection/Traits/Functional/InPlaceSort.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mergeSort has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function mergeSort(callable $callback)
    {
        $count = $this->count();
        $sfa = $this->getValues();
Severity: Minor
Found in Mbh/Collection/Traits/Functional/ImmutableSort.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File LinkedList.php has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace Mbh\Collection\Traits\Sequenceable;

use Mbh\Collection\Interfaces\Collection as CollectionInterface;
use Mbh\Collection\Interfaces\Functional as FunctionalInterface;
use Mbh\Collection\Interfaces\Sequenceable as SequenceableInterface;
Severity: Minor
Found in Mbh/Collection/Traits/Sequenceable/LinkedList.php - About 2 hrs to fix

Method mergeSort has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function mergeSort(callable $callback)
    {
        $count = $this->count();
        $sfa = $this->getValues();
Severity: Minor
Found in Mbh/Collection/Traits/Functional/ImmutableSort.php - About 1 hr to fix

Method mergeSort has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function mergeSort(callable $callback)
    {
        $count = $this->count();
        $result = new SplFixedArray($count);
Severity: Minor
Found in Mbh/Collection/Traits/Functional/InPlaceSort.php - About 1 hr to fix

Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(...$args)
    {
        parent::__construct();

        foreach ($args as $i => $iterator) {
Severity: Minor
Found in Mbh/Iterator/ConcatIterator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function join has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function join(string $token = ',', string $secondToken = null): string
    {
        $str = "";
        if ($secondToken !== null) {
            foreach ($this as $i => $elem) {
Severity: Minor
Found in Mbh/Collection/Traits/ImmutableFunctional.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function join has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function join(string $token = ',', string $secondToken = null): string
    {
        $str = "";
        if ($secondToken !== null) {
            foreach ($this as $i => $elem) {
Severity: Minor
Found in Mbh/Collection/Traits/Functional.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language