Sign upLogin

MPOS/php-mpos

View on GitHub
Star
include/classes/mail.class.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method sendMail has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public function sendMail($template, $aData, $throttle=false) {
    // Prepare SMTP transport and mailer
    $transport_type = $this->config['swiftmailer']['type'];
    if ($transport_type == 'sendmail') {
      $transport = Swift_SendmailTransport::newInstance($this->config['swiftmailer'][$transport_type]['path'] . ' ' . $this->config['swiftmailer'][$transport_type]['options']);
Severity: Minor
Found in include/classes/mail.class.php - About 1 hr to fix

    Function sendMail has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      public function sendMail($template, $aData, $throttle=false) {
    // Prepare SMTP transport and mailer
    $transport_type = $this->config['swiftmailer']['type'];
    if ($transport_type == 'sendmail') {
      $transport = Swift_SendmailTransport::newInstance($this->config['swiftmailer'][$transport_type]['path'] . ' ' . $this->config['swiftmailer'][$transport_type]['options']);
    Severity: Minor
    Found in include/classes/mail.class.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

        return false;
    Severity: Major
    Found in include/classes/mail.class.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status