MPOS/php-mpos

View on GitHub
include/smarty/libs/plugins/modifier.escape.php

Summary

Maintainability
F
3 days
Test Coverage

Function smarty_modifier_escape has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

function smarty_modifier_escape($string, $esc_type = 'html', $char_set = null, $double_encode = true)
{
    static $_double_encode = null;
    if ($_double_encode === null) {
        $_double_encode = version_compare(PHP_VERSION, '5.2.3', '>=');
Severity: Minor
Found in include/smarty/libs/plugins/modifier.escape.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method smarty_modifier_escape has 126 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function smarty_modifier_escape($string, $esc_type = 'html', $char_set = null, $double_encode = true)
{
    static $_double_encode = null;
    if ($_double_encode === null) {
        $_double_encode = version_compare(PHP_VERSION, '5.2.3', '>=');
Severity: Major
Found in include/smarty/libs/plugins/modifier.escape.php - About 5 hrs to fix

    Avoid too many return statements within this method.
    Open

                        return htmlentities($string, ENT_QUOTES, $char_set);
    Severity: Major
    Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return preg_replace("%(?<!\\\\)'%", "\\'", $string);
      Severity: Major
      Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $return;
        Severity: Major
        Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return $string;
          Severity: Major
          Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return str_replace(array('@', '.'), array(' [AT] ', ' [DOT] '), $string);
            Severity: Major
            Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $return;
              Severity: Major
              Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return htmlentities($string, ENT_QUOTES, $char_set, $double_encode);
                Severity: Major
                Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return $return;
                  Severity: Major
                  Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $return;
                    Severity: Major
                    Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return str_replace('%2F', '/', rawurlencode($string));
                      Severity: Major
                      Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return smarty_mb_str_replace(array('@', '.'), array(' [AT] ', ' [DOT] '), $string);
                        Severity: Major
                        Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return $return;
                          Severity: Major
                          Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return $return;
                            Severity: Major
                            Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return rawurlencode($string);
                              Severity: Major
                              Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return $return;
                                Severity: Major
                                Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return strtr($string, array('\\' => '\\\\', "'" => "\\'", '"' => '\\"', "\r" => '\\r', "\n" => '\\n', '</' => '<\/'));
                                  Severity: Major
                                  Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return $string;
                                    Severity: Major
                                    Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                      return mb_convert_encoding($string, 'HTML-ENTITIES', $char_set);
                                      Severity: Major
                                      Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                                        Identical blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                                    if ($_double_encode) {
                                                        // php >=5.3.2 - go native
                                                        return htmlspecialchars($string, ENT_QUOTES, $char_set, $double_encode);
                                                    } else {
                                                        if ($double_encode) {
                                        Severity: Major
                                        Found in include/smarty/libs/plugins/modifier.escape.php and 1 other location - About 2 hrs to fix
                                        include/smarty/libs/plugins/modifier.escape.php on lines 79..91

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 137.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Identical blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                                    if ($_double_encode) {
                                                        return htmlentities($string, ENT_QUOTES, $char_set, $double_encode);
                                                    } else {
                                                        if ($double_encode) {
                                                            return htmlentities($string, ENT_QUOTES, $char_set);
                                        Severity: Major
                                        Found in include/smarty/libs/plugins/modifier.escape.php and 1 other location - About 2 hrs to fix
                                        include/smarty/libs/plugins/modifier.escape.php on lines 37..52

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 137.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        There are no issues that match your filters.

                                        Category
                                        Status