Sign upLogin

ManageIQ/azure-armrest

View on GitHub
Star
lib/azure/armrest/insights/metrics_service.rb

Summary

Maintainability
A
1 hr
Test Coverage
F
30%

Method list has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def list(provider, resource_type, resource_name, resource_group = nil, options = {})
Severity: Minor
Found in lib/azure/armrest/insights/metrics_service.rb - About 35 mins to fix

    Method build_url has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def build_url(provider, resource_type, resource_name, resource_group, options)
    Severity: Minor
    Found in lib/azure/armrest/insights/metrics_service.rb - About 35 mins to fix

      Method list_metrics has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def list_metrics(resource, options = {})
          resource_id = resource.respond_to?(:id) ? resource.id : resource
          options[:filter] = options if options.is_a?(String) # For backwards compatibility

          url = File.join(
      Severity: Minor
      Found in lib/azure/armrest/insights/metrics_service.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status