Sign upLogin

ManageIQ/manageiq-providers-vmware

View on GitHub
Star
app/models/manageiq/providers/vmware/cloud_manager/ovf_template.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
94%

Wrap expressions with varying precedence with parentheses to avoid ambiguity.
Open

        disk.capacity_mb = int(d, disk_xpaths(:capacity), :default => 0) / 2**20 # B -> MB
Severity: Minor
Found in app/models/manageiq/providers/vmware/cloud_manager/ovf_template.rb by rubocop

Looks for expressions containing multiple binary operators where precedence is ambiguous due to lack of parentheses. For example, in 1 + 2 * 3, the multiplication will happen before the addition, but lexically it appears that the addition will happen first.

The cop does not consider unary operators (ie. !a or -b) or comparison operators (ie. a =~ b) because those are not ambiguous.

NOTE: Ranges are handled by Lint/AmbiguousRange.

Example:

# bad
a + b * c
a || b && c
a ** b + c

# good (different precedence)
a + (b * c)
a || (b && c)
(a ** b) + c

# good (same precedence)
a + b + c
a * b / c % d

There are no issues that match your filters.

Category
Status