Method dialog_get_form_vars
has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring. Open
def dialog_get_form_vars
@record = Dialog.find(@edit[:rec_id])
params.each do |parameter_key, parameter_value|
parameter_key = parameter_key.split("__protected").first if parameter_key.ends_with?("__protected")
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method dialog_form_button_pressed
has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open
def dialog_form_button_pressed
case params[:button]
when "cancel"
return unless load_edit("dialog_edit__#{params[:id]}", "replace_cell__explorer")
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Cyclomatic complexity for dialog_get_form_vars is too high. [18/11] Open
def dialog_get_form_vars
@record = Dialog.find(@edit[:rec_id])
params.each do |parameter_key, parameter_value|
parameter_key = parameter_key.split("__protected").first if parameter_key.ends_with?("__protected")
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6
Method dialog_form_button_pressed
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
def dialog_form_button_pressed
case params[:button]
when "cancel"
return unless load_edit("dialog_edit__#{params[:id]}", "replace_cell__explorer")
- Create a ticketCreate a ticket
Cyclomatic complexity for dialog_form_button_pressed is too high. [14/11] Open
def dialog_form_button_pressed
case params[:button]
when "cancel"
return unless load_edit("dialog_edit__#{params[:id]}", "replace_cell__explorer")
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6
Method dialog_get_form_vars
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
def dialog_get_form_vars
@record = Dialog.find(@edit[:rec_id])
params.each do |parameter_key, parameter_value|
parameter_key = parameter_key.split("__protected").first if parameter_key.ends_with?("__protected")
- Create a ticketCreate a ticket
Avoid deeply nested control flow statements. Open
if result[:request].nil?
dialog_replace_right_cell
else
flash_to_session
javascript_redirect(:controller => 'miq_request', :action => 'show_list')
- Create a ticketCreate a ticket
Avoid more than 3 levels of block nesting. Open
if session[:edit][:explorer]
if result[:request].nil?
dialog_replace_right_cell
else
flash_to_session
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks for excessive nesting of conditional and looping constructs.
You can configure if blocks are considered using the CountBlocks
option. When set to false
(the default) blocks are not counted
towards the nesting level. Set to true
to count blocks as well.
The maximum level of nesting allowed is configurable.
Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant. Open
elsif %w[start_hour start_min].include?(parameter_key)
- Create a ticketCreate a ticket
- Exclude checks