Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/controllers/restful_redirect_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
100%

Method index has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    case params[:model]
    when 'ExtManagementSystem'
      record = ExtManagementSystem.find_by(:id => params[:id])
      if record
Severity: Minor
Found in app/controllers/restful_redirect_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method index has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def index
    case params[:model]
    when 'ExtManagementSystem'
      record = ExtManagementSystem.find_by(:id => params[:id])
      if record
Severity: Minor
Found in app/controllers/restful_redirect_controller.rb - About 1 hr to fix

Avoid more than 3 levels of block nesting.
Open

          rescue NoMethodError
            flash_to_session(_("Cannot redirect to \"%{record}\" provider.") % {:record => record.name}, :error)
            redirect_to(:controller => 'ops', :action => 'explorer')
Severity: Minor
Found in app/controllers/restful_redirect_controller.rb by rubocop

Checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

There are no issues that match your filters.

Category
Status