ManageIQ/manageiq

View on GitHub
app/models/chargeback.rb

Summary

Maintainability
A
35 mins
Test Coverage
D
65%

Method set_chargeback_report_options has a Cognitive Complexity of 13 (exceeds 11 allowed). Consider refactoring.
Open

  def self.set_chargeback_report_options(rpt, group_by, header_for_tag, groupby_label, tz)
    rpt.cols = %w(start_date display_range)

    static_cols       = report_static_cols
    static_cols      -= ["image_name"] if group_by == "project"
Severity: Minor
Found in app/models/chargeback.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use #key? instead of #keys.include?.
Open

          next unless report_col_options.keys.include?("#{chargeable_field.rate_name}_cost")
Severity: Minor
Found in app/models/chargeback.rb by rubocop

There are no issues that match your filters.

Category
Status