app/models/ext_management_system.rb
Cyclomatic complexity for inventory_status is too high. [12/11] Open
Open
def self.inventory_status
data = includes(:zone)
.select(:id, :parent_ems_id, :zone_id, :type, :name, :total_hosts, :total_vms, :total_clusters)
.map do |ems|
[
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6
Use block explicitly instead of block-passing a method object. Open
Open
ems.authentications = authentications.map(&method(:assign_nested_authentication))
- Create a ticketCreate a ticket
- Exclude checks
Use block explicitly instead of block-passing a method object. Open
Open
ems.endpoints = endpoints.map(&method(:assign_nested_endpoint))
- Create a ticketCreate a ticket
- Exclude checks
Use filter_map
instead. Open
Open
chosen_endpoints = options.map { |x| x.deep_symbolize_keys.fetch_path(:endpoint, :role).try(:to_sym) }.compact.uniq
- Create a ticketCreate a ticket
- Exclude checks
Use filter_map
instead. Open
Open
existing_hostnames = (self.class.all - [self]).map(&:hostname).compact.map(&:downcase)
- Create a ticketCreate a ticket
- Exclude checks