ManageIQ/manageiq

View on GitHub
app/models/ext_management_system.rb

Summary

Maintainability
A
0 mins
Test Coverage
B
80%

Cyclomatic complexity for inventory_status is too high. [12/11]
Open

  def self.inventory_status
    data = includes(:zone)
           .select(:id, :parent_ems_id, :zone_id, :type, :name, :total_hosts, :total_vms, :total_clusters)
           .map do |ems|
             [
Severity: Minor
Found in app/models/ext_management_system.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Use block explicitly instead of block-passing a method object.
Open

        ems.authentications = authentications.map(&method(:assign_nested_authentication))
Severity: Minor
Found in app/models/ext_management_system.rb by rubocop

Use block explicitly instead of block-passing a method object.
Open

        ems.endpoints = endpoints.map(&method(:assign_nested_endpoint))
Severity: Minor
Found in app/models/ext_management_system.rb by rubocop

Use filter_map instead.
Open

    chosen_endpoints = options.map { |x| x.deep_symbolize_keys.fetch_path(:endpoint, :role).try(:to_sym) }.compact.uniq
Severity: Minor
Found in app/models/ext_management_system.rb by rubocop

Use filter_map instead.
Open

    existing_hostnames = (self.class.all - [self]).map(&:hostname).compact.map(&:downcase)
Severity: Minor
Found in app/models/ext_management_system.rb by rubocop

There are no issues that match your filters.

Category
Status