ManageIQ/manageiq

View on GitHub
app/models/miq_region_remote.rb

Summary

Maintainability
A
45 mins
Test Coverage
F
41%

Method validate_connection_settings has a Cognitive Complexity of 14 (exceeds 11 allowed). Consider refactoring.
Open

  def self.validate_connection_settings(host, port, username, password, database = nil, adapter = nil)
    database, adapter = prepare_default_fields(database, adapter)

    log_details = "Host: [#{host}]}, Database: [#{database}], Adapter: [#{adapter}], User: [#{username}]"

Severity: Minor
Found in app/models/miq_region_remote.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid parameter lists longer than 5 parameters. [8/5]
Open

  def self.region_valid?(guid, region, host, port, username, password, database = nil, adapter = nil)
Severity: Minor
Found in app/models/miq_region_remote.rb by rubocop

This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

Avoid parameter lists longer than 5 parameters. [7/5]
Open

  def self.with_remote_connection(host, port, username, password, database, adapter, connect_timeout = 0)
Severity: Minor
Found in app/models/miq_region_remote.rb by rubocop

This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

Avoid parameter lists longer than 5 parameters. [6/5]
Open

  def self.validate_connection_settings(host, port, username, password, database = nil, adapter = nil)
Severity: Minor
Found in app/models/miq_region_remote.rb by rubocop

This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

Avoid parameter lists longer than 5 parameters. [6/5]
Open

  def self.db_ping(host, port, username, password, database = nil, adapter = nil)
Severity: Minor
Found in app/models/miq_region_remote.rb by rubocop

This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

There are no issues that match your filters.

Category
Status