app/models/mixins/miq_provision_quota_mixin.rb
Method quota_find_vms_by_group
has a Cognitive Complexity of 13 (exceeds 11 allowed). Consider refactoring. Open
Open
def quota_find_vms_by_group(options)
vms = []
prov_owner = get_owner
unless prov_owner.nil?
vms = Vm.where("miq_group_id = ?", prov_owner.current_group_id).includes(:hardware => :disks)
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Use filter_map
instead. Open
Open
requests.collect { |request| request unless request.id == skip_id }.compact
- Create a ticketCreate a ticket
- Exclude checks