ManageIQ/manageiq

lib/miq_expression/subst_mixin.rb

Summary

B
5 hrs

Method `exp_build_table` has a Cognitive Complexity of 34 (exceeds 11 allowed). Consider refactoring. Open

``````  def exp_build_table(exp, quick_search = false)
exp_table = []
if exp["and"]
exp_table.push("(")
exp["and"].each do |e|``````
Found in lib/miq_expression/subst_mixin.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

Cyclomatic complexity for exp_build_table is too high. [12/11] Open

``````  def exp_build_table(exp, quick_search = false)
exp_table = []
if exp["and"]
exp_table.push("(")
exp["and"].each do |e|``````
Found in lib/miq_expression/subst_mixin.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method `exp_find_by_token` has a Cognitive Complexity of 12 (exceeds 11 allowed). Consider refactoring. Open

``````  def exp_find_by_token(exp, token, parent_is_not = false)
if exp.kind_of?(Array)                             # Is this and AND or OR
result = nil
exp.find do |e|
result = exp_find_by_token(e, token) # Look for token``````
Found in lib/miq_expression/subst_mixin.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

Method `exp_replace_qs_tokens` has a Cognitive Complexity of 12 (exceeds 11 allowed). Consider refactoring. Open

``````  def exp_replace_qs_tokens(exp, tokens)
key = exp.keys.first
if %w(and or).include?(key)
exp[key].each { |e| exp_replace_qs_tokens(e, tokens) }
elsif key == "not"``````
Found in lib/miq_expression/subst_mixin.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

Similar blocks of code found in 2 locations. Consider refactoring. Open

``````      exp_table.push("(")
exp["and"].each do |e|
exp_table += exp_build_table(e, quick_search)
exp_table.push("AND") unless e == exp["and"].last
end``````
Found in lib/miq_expression/subst_mixin.rb and 1 other location - About 25 mins to fix
lib/miq_expression/subst_mixin.rb on lines 20..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

Refactorings

Similar blocks of code found in 2 locations. Consider refactoring. Open

``````      exp_table.push("(")
exp["or"].each do |e|
exp_table += exp_build_table(e, quick_search)
exp_table.push("OR") unless e == exp["or"].last
end``````
Found in lib/miq_expression/subst_mixin.rb and 1 other location - About 25 mins to fix
lib/miq_expression/subst_mixin.rb on lines 13..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.