ManageIQ/manageiq

View on GitHub
tools/radar/rollup_radar_mixin_spec.rb

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      let(:metrics_settings) do
        t = month_beginning

        sett = {}
        sett[container_a] = {}
Severity: Major
Found in tools/radar/rollup_radar_mixin_spec.rb and 1 other location - About 4 hrs to fix
tools/radar/rollup_radar_mixin_spec.rb on lines 149..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    let(:metrics_settings) do
      t = month_beginning

      sett = {}
      sett[container_a] = {}
Severity: Major
Found in tools/radar/rollup_radar_mixin_spec.rb and 1 other location - About 4 hrs to fix
tools/radar/rollup_radar_mixin_spec.rb on lines 202..230

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it 'calculates rollups' do
      results = get_hourly_maxes_per_group("com.redhat.component", month_beginning...month_end)

      exp = [{"label_name"             => "com.redhat.component",
              "label_value"            => "EAP7",
Severity: Major
Found in tools/radar/rollup_radar_mixin_spec.rb and 3 other locations - About 45 mins to fix
tools/radar/rollup_radar_mixin_spec.rb on lines 130..144
tools/radar/rollup_radar_mixin_spec.rb on lines 233..247
tools/radar/rollup_radar_mixin_spec.rb on lines 283..297

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it 'calculates rollups' do
      results = get_hourly_maxes_per_group("com.redhat.component", month_beginning...month_end)

      exp = [{"label_name"             => "com.redhat.component",
              "label_value"            => "EAP7",
Severity: Major
Found in tools/radar/rollup_radar_mixin_spec.rb and 3 other locations - About 45 mins to fix
tools/radar/rollup_radar_mixin_spec.rb on lines 184..198
tools/radar/rollup_radar_mixin_spec.rb on lines 233..247
tools/radar/rollup_radar_mixin_spec.rb on lines 283..297

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it 'calculates rollups' do
      results = get_hourly_maxes_per_group("com.redhat.component_different", month_beginning...month_end)

      exp = [{"label_name"             => "com.redhat.component_different",
              "label_value"            => "EAP7",
Severity: Major
Found in tools/radar/rollup_radar_mixin_spec.rb and 3 other locations - About 45 mins to fix
tools/radar/rollup_radar_mixin_spec.rb on lines 130..144
tools/radar/rollup_radar_mixin_spec.rb on lines 184..198
tools/radar/rollup_radar_mixin_spec.rb on lines 233..247

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      it 'calculates rollups' do
        results = get_hourly_maxes_per_group("com.redhat.component", month_beginning...month_end)

        exp = [{"label_name"             => "com.redhat.component",
                "label_value"            => "EAP7",
Severity: Major
Found in tools/radar/rollup_radar_mixin_spec.rb and 3 other locations - About 45 mins to fix
tools/radar/rollup_radar_mixin_spec.rb on lines 130..144
tools/radar/rollup_radar_mixin_spec.rb on lines 184..198
tools/radar/rollup_radar_mixin_spec.rb on lines 283..297

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status