Showing 44 of 44 total issues
Method parse has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring. Open
def parse(cmdline = ARGV)
vals = {}
required = {}
opt :version, "Print version and exit" if @version && ! (@specs[:version] || @long["version"])- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File optimist.rb has 637 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'date'
module Optimist
VERSION = "3.1.0"
Method each_arg has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring. Open
def each_arg(args)
remains = []
i = 0
until i >= args.length- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Cyclomatic complexity for parse is too high. [44/11] Open
def parse(cmdline = ARGV)
vals = {}
required = {}
opt :version, "Print version and exit" if @version && ! (@specs[:version] || @long["version"])- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Method parse has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
def parse(cmdline = ARGV)
vals = {}
required = {}
opt :version, "Print version and exit" if @version && ! (@specs[:version] || @long["version"])Class Parser has 25 methods (exceeds 20 allowed). Consider refactoring. Open
class Parser
## The registry is a class-instance-variable map of option aliases to their subclassed Option class.
@registry = {}
Method each_arg has 69 lines of code (exceeds 25 allowed). Consider refactoring. Open
def each_arg(args)
remains = []
i = 0
until i >= args.lengthCyclomatic complexity for each_arg is too high. [18/11] Open
def each_arg(args)
remains = []
i = 0
until i >= args.length- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Class Option has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class Option
attr_accessor :name, :short, :long, :default
attr_writer :multi_given
Method educate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def educate(stream = $stdout)
width # hack: calculate it now; otherwise we have to be careful not to
# call this unless the cursor's at the beginning of a line.
left = {}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def parse(paramlist, _neg_given)
paramlist.map do |pg|
pg.map do |param|
next param if param.is_a?(Date)
begin- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method wrap_line has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def wrap_line(str, opts = {})
prefix = opts[:prefix] || 0
width = opts[:width] || (self.width - 1)
start = 0
ret = []- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method get_type_from_disdef has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def self.get_type_from_disdef(optdef, opttype, disambiguated_default)
if disambiguated_default.is_a? Array
return(optdef.first.class.name.downcase + "s") if !optdef.empty?
if opttype
raise ArgumentError, "multiple argument type must be plural" unless opttype.multi_arg?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if @stop_on_unknown
remains << "-#{short_remaining}"
return remains += args[i + 1..-1]
endAvoid deeply nested control flow statements. Open
if @stop_on_unknown
short_remaining += shortargs[j + 1..-1].join
remains << "-#{short_remaining}"
return remains += args[i + 1..-1]
endMethod parse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def parse(paramlist, _neg_given)
paramlist.map do |pg|
pg.map do |param|
if param =~ /^(stdin|-)$/i
$stdin- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method resolve_default_short_options! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def resolve_default_short_options!
@order.each do |type, name|
opts = @specs[name]
next if type != :opt || opts.short
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method opt has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def opt(name, desc = "", opts = {}, &b)
opts[:callback] ||= b if block_given?
opts[:desc] ||= desc
o = Option.create(name, desc, opts)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return remains += args[i + 1..-1]Avoid too many return statements within this method. Open
return remains += args[i + 1..-1]