Sign upLogin

MarshallAsch/solitaire

View on GitHub
Star
solitare/Login.java

Summary

Maintainability
D
2 days
Test Coverage

File Login.java has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* Frame and panels where user can log in at the begining of the game to use the desired
 * look and feel settings
 * 
 */
Severity: Minor
Found in solitare/Login.java - About 2 hrs to fix

Method set2 has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

     public void set2(String[] recieve)
     {
          try{
               //add new info to the array
               userName[len] = recieve[0];
Severity: Major
Found in solitare/Login.java - About 2 hrs to fix

Method rebuild has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

     private void rebuild(String user, String pass)
     {
          Document dom;
          Element sub, sub1, sub2, sub3, sub4, sub5, sub6, sub7, sub8, sub9;
          int pileNum = 0, pileIndex = 0;
Severity: Major
Found in solitare/Login.java - About 2 hrs to fix

Method createNewUser has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

     private void createNewUser()
     {
          try
          {
               File inputFile = new File("UserSetings.dtd");  //open file to get all old users
Severity: Minor
Found in solitare/Login.java - About 1 hr to fix

Method login has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

     private void login(String user, String pass)
     {
          //if user and pass is admin open control window
          try
          {
Severity: Minor
Found in solitare/Login.java - About 1 hr to fix

Method login has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

     private void login(String user, String pass)
     {
          //if user and pass is admin open control window
          try
          {
Severity: Minor
Found in solitare/Login.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

               {
                    //put all info back into file
                    sub = dom.createElement("user");
                    sub1 = dom.createElement("userName");
                    sub1.appendChild(dom.createTextNode(userName[i]));
Severity: Major
Found in solitare/Login.java and 1 other location - About 5 hrs to fix
solitare/SettingsPanel.java on lines 324..363

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 346.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

               try {
                    Transformer tr = TransformerFactory.newInstance().newTransformer();
                    tr.setOutputProperty(OutputKeys.INDENT, "yes");
                    tr.setOutputProperty(OutputKeys.METHOD, "xml");
                    tr.setOutputProperty(OutputKeys.ENCODING, "UTF-8");
Severity: Major
Found in solitare/Login.java and 2 other locations - About 1 hr to fix
solitare/Login.java on lines 176..190
solitare/SettingsPanel.java on lines 365..378

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

               try {
                    Transformer tr = TransformerFactory.newInstance().newTransformer();
                    tr.setOutputProperty(OutputKeys.INDENT, "yes");
                    tr.setOutputProperty(OutputKeys.METHOD, "xml");
                    tr.setOutputProperty(OutputKeys.ENCODING, "UTF-8");
Severity: Major
Found in solitare/Login.java and 2 other locations - About 1 hr to fix
solitare/Login.java on lines 316..329
solitare/SettingsPanel.java on lines 365..378

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status