MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-

View on GitHub
src/renderer/ui/components/settings/ThemeOptions.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function render has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    return (
      <SettingsTabWrapper>
        <PlatformSpecific platform="darwin">
          <div style={{ paddingBottom: 16 }}>
Severity: Minor
Found in src/renderer/ui/components/settings/ThemeOptions.js - About 1 hr to fix

    Strings must use singlequote.
    Open

                  settingsKey={"themeTypeShouldTrackSystem"}

    enforce the consistent use of either backticks, double, or single quotes (quotes)

    JavaScript allows you to define strings in one of three ways: double quotes, single quotes, and backticks (as of ECMAScript 6). For example:

    /*eslint-env es6*/
    
    var double = "double";
    var single = 'single';
    var backtick = `backtick`;    // ES6 only

    Each of these lines creates a string and, in some cases, can be used interchangeably. The choice of how to define strings in a codebase is a stylistic one outside of template literals (which allow embedded of expressions to be interpreted).

    Many codebases require strings to be defined in a consistent manner.

    Rule Details

    This rule enforces the consistent use of either backticks, double, or single quotes.

    Options

    This rule has two options, a string option and an object option.

    String option:

    • "double" (default) requires the use of double quotes wherever possible
    • "single" requires the use of single quotes wherever possible
    • "backtick" requires the use of backticks wherever possible

    Object option:

    • "avoidEscape": true allows strings to use single-quotes or double-quotes so long as the string contains a quote that would have to be escaped otherwise
    • "allowTemplateLiterals": true allows strings to use backticks

    Deprecated: The object property avoid-escape is deprecated; please use the object property avoidEscape instead.

    double

    Examples of incorrect code for this rule with the default "double" option:

    /*eslint quotes: ["error", "double"]*/
    
    var single = 'single';
    var unescaped = 'a string containing "double" quotes';

    Examples of correct code for this rule with the default "double" option:

    /*eslint quotes: ["error", "double"]*/
    /*eslint-env es6*/
    
    var double = "double";
    var backtick = `back\ntick`;  // backticks are allowed due to newline
    var backtick = tag`backtick`; // backticks are allowed due to tag

    single

    Examples of incorrect code for this rule with the "single" option:

    /*eslint quotes: ["error", "single"]*/
    
    var double = "double";
    var unescaped = "a string containing 'single' quotes";

    Examples of correct code for this rule with the "single" option:

    /*eslint quotes: ["error", "single"]*/
    /*eslint-env es6*/
    
    var single = 'single';
    var backtick = `back${x}tick`; // backticks are allowed due to substitution

    backticks

    Examples of incorrect code for this rule with the "backtick" option:

    /*eslint quotes: ["error", "backtick"]*/
    
    var single = 'single';
    var double = "double";
    var unescaped = 'a string containing `backticks`';

    Examples of correct code for this rule with the "backtick" option:

    /*eslint quotes: ["error", "backtick"]*/
    /*eslint-env es6*/
    
    var backtick = `backtick`;

    avoidEscape

    Examples of additional correct code for this rule with the "double", { "avoidEscape": true } options:

    /*eslint quotes: ["error", "double", { "avoidEscape": true }]*/
    
    var single = 'a string containing "double" quotes';

    Examples of additional correct code for this rule with the "single", { "avoidEscape": true } options:

    /*eslint quotes: ["error", "single", { "avoidEscape": true }]*/
    
    var double = "a string containing 'single' quotes";

    Examples of additional correct code for this rule with the "backtick", { "avoidEscape": true } options:

    /*eslint quotes: ["error", "backtick", { "avoidEscape": true }]*/
    
    var double = "a string containing `backtick` quotes"

    allowTemplateLiterals

    Examples of additional correct code for this rule with the "double", { "allowTemplateLiterals": true } options:

    /*eslint quotes: ["error", "double", { "allowTemplateLiterals": true }]*/
    
    var double = "double";
    var double = `double`;

    Examples of additional correct code for this rule with the "single", { "allowTemplateLiterals": true } options:

    /*eslint quotes: ["error", "single", { "allowTemplateLiterals": true }]*/
    
    var single = 'single';
    var single = `single`;

    When Not To Use It

    If you do not need consistency in your string styles, you can safely disable this rule. Source: http://eslint.org/docs/rules/

    Unexpected parentheses around single function argument having a body with no curly braces
    Open

                themeColors.map((color) => <div key={color} className={`color-square ${color}`} onClick={this.changeThemeColor}></div>)

    Require parens in arrow function arguments (arrow-parens)

    Arrow functions can omit parentheses when they have exactly one parameter. In all other cases the parameter(s) must be wrapped in parentheses. This rule enforces the consistent use of parentheses in arrow functions.

    Rule Details

    This rule enforces parentheses around arrow function parameters regardless of arity. For example:

    /*eslint-env es6*/
    
    // Bad
    a => {}
    
    // Good
    (a) => {}

    Following this style will help you find arrow functions (=>) which may be mistakenly included in a condition when a comparison such as >= was the intent.

    /*eslint-env es6*/
    
    // Bad
    if (a => 2) {
    }
    
    // Good
    if (a >= 2) {
    }

    The rule can also be configured to discourage the use of parens when they are not required:

    /*eslint-env es6*/
    
    // Bad
    (a) => {}
    
    // Good
    a => {}

    Options

    This rule has a string option and an object one.

    String options are:

    • "always" (default) requires parens around arguments in all cases.
    • "as-needed" allows omitting parens when there is only one argument.

    Object properties for variants of the "as-needed" option:

    • "requireForBlockBody": true modifies the as-needed rule in order to require parens if the function body is in an instructions block (surrounded by braces).

    always

    Examples of incorrect code for this rule with the default "always" option:

    /*eslint arrow-parens: ["error", "always"]*/
    /*eslint-env es6*/
    
    a => {};
    a => a;
    a => {'\n'};
    a.then(foo => {});
    a.then(foo => a);
    a(foo => { if (true) {} });

    Examples of correct code for this rule with the default "always" option:

    /*eslint arrow-parens: ["error", "always"]*/
    /*eslint-env es6*/
    
    () => {};
    (a) => {};
    (a) => a;
    (a) => {'\n'}
    a.then((foo) => {});
    a.then((foo) => { if (true) {} });

    If Statements

    One of benefits of this option is that it prevents the incorrect use of arrow functions in conditionals:

    /*eslint-env es6*/
    
    var a = 1;
    var b = 2;
    // ...
    if (a => b) {
     console.log('bigger');
    } else {
     console.log('smaller');
    }
    // outputs 'bigger', not smaller as expected

    The contents of the if statement is an arrow function, not a comparison.

    If the arrow function is intentional, it should be wrapped in parens to remove ambiguity.

    /*eslint-env es6*/
    
    var a = 1;
    var b = 0;
    // ...
    if ((a) => b) {
     console.log('truthy value returned');
    } else {
     console.log('falsey value returned');
    }
    // outputs 'truthy value returned'

    The following is another example of this behavior:

    /*eslint-env es6*/
    
    var a = 1, b = 2, c = 3, d = 4;
    var f = a => b ? c: d;
    // f = ?

    f is an arrow function which takes a as an argument and returns the result of b ? c: d.

    This should be rewritten like so:

    /*eslint-env es6*/
    
    var a = 1, b = 2, c = 3, d = 4;
    var f = (a) => b ? c: d;

    as-needed

    Examples of incorrect code for this rule with the "as-needed" option:

    /*eslint arrow-parens: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    (a) => {};
    (a) => a;
    (a) => {'\n'};
    a.then((foo) => {});
    a.then((foo) => a);
    a((foo) => { if (true) {} });

    Examples of correct code for this rule with the "as-needed" option:

    /*eslint arrow-parens: ["error", "as-needed"]*/
    /*eslint-env es6*/
    
    () => {};
    a => {};
    a => a;
    a => {'\n'};
    a.then(foo => {});
    a.then(foo => { if (true) {} });
    (a, b, c) => a;
    (a = 10) => a;
    ([a, b]) => a;
    ({a, b}) => a;

    requireForBlockBody

    Examples of incorrect code for the { "requireForBlockBody": true } option:

    /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
    /*eslint-env es6*/
    
    (a) => a;
    a => {};
    a => {'\n'};
    a.map((x) => x * x);
    a.map(x => {
      return x * x;
    });
    a.then(foo => {});

    Examples of correct code for the { "requireForBlockBody": true } option:

    /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
    /*eslint-env es6*/
    
    (a) => {};
    (a) => {'\n'};
    a => ({});
    () => {};
    a => a;
    a.then((foo) => {});
    a.then((foo) => { if (true) {} });
    a((foo) => { if (true) {} });
    (a, b, c) => a;
    (a = 10) => a;
    ([a, b]) => a;
    ({a, b}) => a;

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      static propTypes = {
        themeColor: PropTypes.string.isRequired,
        themeType: PropTypes.string.isRequired,
        themeTypeShouldTrackSystem: PropTypes.bool.isRequired,
        setSetting: PropTypes.func.isRequired,
    Severity: Major
    Found in src/renderer/ui/components/settings/ThemeOptions.js and 1 other location - About 1 hr to fix
    src/renderer/ui/components/settings/FileInput.js on lines 12..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Do not use findDOMNode
    Open

        this.props.setSetting('themeColor', window.getComputedStyle(ReactDOM.findDOMNode(event.target))['background-color']);

    For more information visit Source: http://eslint.org/docs/rules/

    Links must not point to "#". Use a more descriptive href or use a button instead.
    Open

                  <a href="#" onClick={this.openColorPicker}>

    For more information visit Source: http://eslint.org/docs/rules/

    'themeColor' PropType is defined but prop is never used
    Open

        themeColor: PropTypes.string.isRequired,

    For more information visit Source: http://eslint.org/docs/rules/

    JSX not allowed in files with extension '.js'
    Open

          <SettingsTabWrapper>

    For more information visit Source: http://eslint.org/docs/rules/

    Visible, non-interactive elements should not have mouse or keyboard event listeners
    Open

                themeColors.map((color) => <div key={color} className={`color-square ${color}`} onClick={this.changeThemeColor}></div>)

    For more information visit Source: http://eslint.org/docs/rules/

    Empty components are self-closing
    Open

                themeColors.map((color) => <div key={color} className={`color-square ${color}`} onClick={this.changeThemeColor}></div>)

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status