MikaAK/s3-plugin-webpack

View on GitHub
src/s3_plugin.js

Summary

Maintainability
C
1 day
Test Coverage

File s3_plugin.js has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import http from 'http'
import https from 'https'
import fs from 'fs'
import path from 'path'
import ProgressBar from 'progress'
Severity: Minor
Found in src/s3_plugin.js - About 3 hrs to fix

    exports has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    module.exports = class S3Plugin {
      constructor(options = {}) {
        var {
          include,
          exclude,
    Severity: Minor
    Found in src/s3_plugin.js - About 2 hrs to fix

      Function constructor has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor(options = {}) {
          var {
            include,
            exclude,
            progress,
      Severity: Minor
      Found in src/s3_plugin.js - About 1 hr to fix

        Function invalidateCloudfront has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          invalidateCloudfront() {
            const {clientConfig, cloudfrontInvalidateOptions} = this
        
            if (cloudfrontInvalidateOptions.DistributionId) {
              const {
        Severity: Minor
        Found in src/s3_plugin.js - About 1 hr to fix

          Function apply has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            apply(compiler) {
              this.connect()
          
              const isDirectoryUpload = !!this.options.directory,
                    hasRequiredUploadOpts = _.every(
          Severity: Minor
          Found in src/s3_plugin.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      return this.getAssetFiles(compilation)
                        .then((files) => this.handleFiles(files))
                        .catch((e) => this.handleErrors(e, compilation))
            Severity: Minor
            Found in src/s3_plugin.js and 1 other location - About 50 mins to fix
            src/s3_plugin.js on lines 112..114

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      return this.getAllFilesRecursive(dPath)
                        .then((files) => this.handleFiles(files))
                        .catch((e) => this.handleErrors(e, compilation))
            Severity: Minor
            Found in src/s3_plugin.js and 1 other location - About 50 mins to fix
            src/s3_plugin.js on lines 116..118

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status