Showing 6 of 165 total issues
Function _returnConnection
has a Cognitive Complexity of 9 (exceeds 6 allowed). Consider refactoring. Confirmed
private func _returnConnection(_ connection: RedisConnection, logger: Logger) {
self.loop.assertInEventLoop()
guard connection.isConnected else {
// This connection isn't active anymore. We'll dump it and potentially kick off a reconnection.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function parseBytesV2
has a Cognitive Complexity of 9 (exceeds 6 allowed). Consider refactoring. Open
private func parseBytesV2(from buffer: inout ByteBuffer) throws -> RESPValue? {
var copy = buffer
guard let token = copy.readInteger(as: UInt8.self) else { return nil }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _leaseConnection
has a Cognitive Complexity of 9 (exceeds 6 allowed). Consider refactoring. Confirmed
private func _leaseConnection(logger: Logger, deadline: NIODeadline) -> EventLoopFuture<RedisConnection> {
self.loop.assertInEventLoop()
guard case .active = self.state else {
logger.trace("attempted to lease connection from closed pool")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function triggerUserOutboundEvent
has a Cognitive Complexity of 8 (exceeds 6 allowed). Consider refactoring. Open
public func triggerUserOutboundEvent(context: ChannelHandlerContext, event: Any, promise: EventLoopPromise<Void>?) {
switch event {
case is RedisGracefulConnectionCloseEvent:
switch self.state {
case .default:
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _mapSortedSetResponse
has a Cognitive Complexity of 8 (exceeds 6 allowed). Consider refactoring. Confirmed
fileprivate static func _mapSortedSetResponse(_ response: [RESPValue], scoreIsFirst: Bool) throws -> [(RESPValue, Double)] {
let responseCount = response.count
guard responseCount > 0 else { return [] }
var result: [(RESPValue, Double)] = []
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function parseArray
has a Cognitive Complexity of 8 (exceeds 6 allowed). Consider refactoring. Confirmed
internal func parseArray(from buffer: inout ByteBuffer) throws -> RESPValue? {
guard let elementCount = try parseInteger(from: &buffer) else { return nil }
guard elementCount > -1 else { return .null } // '*-1\r\n'
guard elementCount > 0 else { return .array([]) } // '*0\r\n'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"