Muterra/py_smartyparse

View on GitHub

Showing 14 of 14 total issues

File core.py has 948 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'''
LICENSING
-------------------------------------------------

Smartyparse: A python library for smart dynamic binary de/encoding.
Severity: Major
Found in smartyparse/core.py - About 2 days to fix

    Function _smartyobject has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

    def _smartyobject(fieldnames):
        ''' Class generator function for SmartyParser objects.
        '''
        # # Handle fieldnames
        # stripped_fieldnames = []
    Severity: Minor
    Found in smartyparse/core.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    _ParsableBase has 28 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class _ParsableBase(metaclass=abc.ABCMeta):
        ''' Base class for anything parsable. Subclassed by both ParseHelper
        and SmartyParser.
        '''
        
    Severity: Minor
    Found in smartyparse/core.py - About 3 hrs to fix

      Cyclomatic complexity is too high in method unpack. (9)
      Open

          def unpack(self, unpack_from):
              with self._mutex:
                  # print(self.length)
                  # Create output object and reframe as memoryview to avoid copies
                  unpacked = []
      Severity: Minor
      Found in smartyparse/core.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method pack. (8)
      Open

          def pack(self, obj, pack_into=None):
              ''' Automatically assembles a message from an object. The object
              must have data accessible via __getitem__(key), with keys
              matching the SmartyParser definition.
              
      Severity: Minor
      Found in smartyparse/core.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method _infer_length. (8)
      Open

          def _infer_length(self, data_length=None):
              ''' Attempts to infer length from the parser, or, barring that,
              from the data itself.
              
              IF PASSING DATA, MAKE SURE IT'S BYTES! Otherwise, expect errors,
      Severity: Minor
      Found in smartyparse/core.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method unpack. (6)
      Open

          def unpack(self, unpack_from):
              ''' Automatically unpacks an object from message.
              
              Returns a SmartyParseObject.
              '''
      Severity: Minor
      Found in smartyparse/core.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function pack has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def pack(self, obj, pack_into=None):
              ''' Automatically assembles a message from an object. The object
              must have data accessible via __getitem__(key), with keys
              matching the SmartyParser definition.
              
      Severity: Minor
      Found in smartyparse/core.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function unpack has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def unpack(self, unpack_from):
              with self._mutex:
                  # print(self.length)
                  # Create output object and reframe as memoryview to avoid copies
                  unpacked = []
      Severity: Minor
      Found in smartyparse/core.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function link_forward has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def link_forward(self, source_name, link_name, f_pack, f_unpack, exclude=True):
      Severity: Minor
      Found in smartyparse/core.py - About 35 mins to fix

        Function link_backward has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def link_backward(self, source_name, link_name, f_pack, f_unpack, exclude=True):
        Severity: Minor
        Found in smartyparse/core.py - About 35 mins to fix

          Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, parsers, terminant=None, require_term=True, offset=0,
          Severity: Minor
          Found in smartyparse/core.py - About 35 mins to fix

            Function __init__ has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def __init__(self, length=None):
                    # Try a numeric comparison to evaluate typing on length
                    if length != None:
                        try:
                            if int(length) != length:
            Severity: Minor
            Found in smartyparse/parsers.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _infer_length has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def _infer_length(self, data_length=None):
                    ''' Attempts to infer length from the parser, or, barring that,
                    from the data itself.
                    
                    IF PASSING DATA, MAKE SURE IT'S BYTES! Otherwise, expect errors,
            Severity: Minor
            Found in smartyparse/core.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language