NatLibFi/fixura-mongo-js

View on GitHub

Showing 9 of 9 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        return new Promise((resolve, reject) => {
          const outputStream = gridFSBucket.openUploadStream(filename);

          outputStream
            .on('error', reject)
Severity: Major
Found in src/gridfs.js and 1 other location - About 1 hr to fix
src/index.spec.js on lines 320..329

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return Promise.all(Object.keys(files).map(filename => new Promise((resolve, reject) => {
      const uploadSteam = gridFSBucket.openUploadStream(filename);

      uploadSteam
        .on('error', reject)
Severity: Major
Found in src/index.spec.js and 1 other location - About 1 hr to fix
src/gridfs.js on lines 53..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getDocuments has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async function getDocuments(collectionRef) {
    if (Array.isArray(collectionRef)) {
      const results = await Promise.all(collectionRef.map(async collection => {
        const docs = await get(collection);
        return {name: collection.collectionName, docs};
Severity: Minor
Found in src/index.spec.js - About 1 hr to fix

    Function populate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async function populate(input) {
        const data = Array.isArray(input) ? clone(getFixture({components: input})) : clone(input);
        const client = await getClient();
    
        await clear();
    Severity: Minor
    Found in src/index.js - About 1 hr to fix

      Function populateFiles has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async function populateFiles(data) {
          await clearFiles();
      
          return Promise.all(Object.keys(data).map(filename => {
            if (typeof data[filename] === 'string') {
      Severity: Minor
      Found in src/gridfs.js - About 1 hr to fix

        Function dumpFiles has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function dumpFiles(readData = false) {
            return new Promise((resolve, reject) => {
              const processors = [];
              const data = {};
        
        
        Severity: Minor
        Found in src/gridfs.js - About 1 hr to fix

          Function get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function get(collection) {
                return new Promise((resolve, reject) => {
                  const docs = [];
          
                  collection.find({})
          Severity: Minor
          Found in src/index.spec.js - About 1 hr to fix

            Function default has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            export default async function ({rootPath, gridFS = false, useObjectId = false, format} = {}) {
              const {getFixture} = fixturesFactory({root: rootPath, reader: READERS.JSON});
              const {getUri, closeCallback} = getMongoMethods();
            
              if (gridFS) {
            Severity: Minor
            Found in src/index.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function default has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            export default function ({client, rootPath, bucketName = 'fs'} = {}) {
              const gridFSBucket = new GridFSBucket(client.db(), {bucketName});
              const {getFixture} = fixturesFactory({root: rootPath, reader: READERS.STREAM});
            
              return {populateFiles, dumpFiles, clearFiles};
            Severity: Minor
            Found in src/gridfs.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language