NatLibFi/marc-record-js

View on GitHub
src/index.spec.js

Summary

Maintainability
F
3 days
Test Coverage

Function doTest has 203 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function doTest(metadata) {

    // Get input & expected output
    const {getFixture} = metadata;
    const {input, result, immutable, noinput, validationOptions} = metadata;
Severity: Major
Found in src/index.spec.js - About 1 day to fix

    Function runOperation has 162 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function runOperation(op) {
          const {name, args} = op;
    
          //-------------------------------------------------------------------------
          if (name === 'nop') {
    Severity: Major
    Found in src/index.spec.js - About 6 hrs to fix

      Avoid too many return statements within this function.
      Open

              return record.get(what);
      Severity: Major
      Found in src/index.spec.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return cloned;
        Severity: Major
        Found in src/index.spec.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return record;
          Severity: Major
          Found in src/index.spec.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return record.toObject();
            Severity: Major
            Found in src/index.spec.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return record.getTypeOfMaterial();
              Severity: Major
              Found in src/index.spec.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return record;
                Severity: Major
                Found in src/index.spec.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                            return new MarcRecord({leader, fields}, validationOptions);
                  Severity: Major
                  Found in src/index.spec.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return record.getControlfields();
                    Severity: Major
                    Found in src/index.spec.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                return record.isCF();
                      Severity: Major
                      Found in src/index.spec.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return created;
                        Severity: Major
                        Found in src/index.spec.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return fields;
                          Severity: Major
                          Found in src/index.spec.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return record;
                            Severity: Major
                            Found in src/index.spec.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return record;
                              Severity: Major
                              Found in src/index.spec.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return MarcRecord.getValidationOptions();
                                Severity: Major
                                Found in src/index.spec.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                          return result;
                                  Severity: Major
                                  Found in src/index.spec.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                              return record.isCR();
                                    Severity: Major
                                    Found in src/index.spec.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                              return false;
                                      Severity: Major
                                      Found in src/index.spec.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                                  return record.isMU();
                                        Severity: Major
                                        Found in src/index.spec.js - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                    return record.isMX();
                                          Severity: Major
                                          Found in src/index.spec.js - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                      return record.isVM();
                                            Severity: Major
                                            Found in src/index.spec.js - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                        return record.pop(what); // eslint-disable-line functional/immutable-data
                                              Severity: Major
                                              Found in src/index.spec.js - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                        return MarcRecord.setValidationOptions(args);
                                                Severity: Major
                                                Found in src/index.spec.js - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                            return record.isBK();
                                                  Severity: Major
                                                  Found in src/index.spec.js - About 30 mins to fix

                                                    Avoid too many return statements within this function.
                                                    Open

                                                              return record.isMP();
                                                    Severity: Major
                                                    Found in src/index.spec.js - About 30 mins to fix

                                                      Avoid too many return statements within this function.
                                                      Open

                                                              return record.getDatafields();
                                                      Severity: Major
                                                      Found in src/index.spec.js - About 30 mins to fix

                                                        Avoid too many return statements within this function.
                                                        Open

                                                                return record.toString().split('\n');
                                                        Severity: Major
                                                        Found in src/index.spec.js - About 30 mins to fix

                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                          Open

                                                            generateTests({
                                                              callback: doTest,
                                                              path: [__dirname, '..', 'test-fixtures', 'index'],
                                                              useMetadataFile: true,
                                                              recurse: true,
                                                          Severity: Minor
                                                          Found in src/index.spec.js and 1 other location - About 50 mins to fix
                                                          src/marcFieldSort.spec.js on lines 11..20

                                                          Duplicated Code

                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                          Tuning

                                                          This issue has a mass of 52.

                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                          Refactorings

                                                          Further Reading

                                                          There are no issues that match your filters.

                                                          Category
                                                          Status