NatLibFi/marc-record-validators-melinda

Similar blocks of code found in 19 locations. Consider refactoring.

Open

    {
      'tag': '995',
      'repeatable': true,
      'fieldType': 'dataField',
      'indicators': {'ind1': ' ', 'ind2': ' '},

• Read up
  Read up

Similar blocks of code found in 19 locations. Consider refactoring.

Open

    {
      'tag': '903',
      'repeatable': true,
      'fieldType': 'dataField',
      'indicators': {'ind1': ' ', 'ind2': ' '},

• Read up
  Read up

Similar blocks of code found in 19 locations. Consider refactoring.

Open

    {
      'tag': '907',
      'repeatable': true,
      'fieldType': 'dataField',
      'indicators': {'ind1': ' ', 'ind2': ' '},

• Read up
  Read up

Similar blocks of code found in 19 locations. Consider refactoring.

Open

    {
      'tag': '902',
      'repeatable': true,
      'fieldType': 'dataField',
      'indicators': {'ind1': ' ', 'ind2': ' '},

• Read up
  Read up

Similar blocks of code found in 19 locations. Consider refactoring.

Open

    {
      'tag': '904',
      'repeatable': true,
      'fieldType': 'dataField',
      'indicators': {'ind1': ' ', 'ind2': ' '},

• Read up
  Read up

Similar blocks of code found in 19 locations. Consider refactoring.

Open

    {
      'tag': '905',
      'repeatable': true,
      'fieldType': 'dataField',
      'indicators': {'ind1': ' ', 'ind2': ' '},

• Read up
  Read up

Similar blocks of code found in 19 locations. Consider refactoring.

Open

    {
      'tag': '025',
      'repeatable': true,
      'fieldType': 'dataField',
      'indicators': {'ind1': ' ', 'ind2': ' '},

• Read up
  Read up

Similar blocks of code found in 19 locations. Consider refactoring.

Open

    {
      'tag': '887',
      'repeatable': true,
      'fieldType': 'dataField',
      'indicators': {'ind1': ' ', 'ind2': ' '},

• Read up
  Read up

Function validateField has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function validateField(value, spec, tag) {
      const messagePrefix = tag ? `Field ${tag}` : 'Leader';

      if (typeof spec.length === 'number') {
        if (value.length !== spec.length) {

Function default has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export default function () {

  return {
    description: 'Justify left and sort character groups within 008/18-24',
    validate, fix

Function default has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export default function (tagPattern) {
  if (tagPattern instanceof RegExp) {
    return {
      description:
        'Handles data fields that only differ in the first indicator',

Function getRelevantFields has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function getRelevantFields(record) {
    //return record.get(/^(?:020|022)$/u).filter(field => {
    return record.fields.filter(field => {
      if (!field.subfields) {
        return false;

Function processCharacterGroup has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function processCharacterGroup(field, group) {
  const originalContent = field.value.substring(group.start, group.end + 1);
  const content = removeDuplicateValues(fixBlanks(originalContent));
  //console.info(`008/${group.start}-${group.end}: '${originalContent}'`); // eslint-disable-line no-console
  const charArray = content.split('');

Function getIndicatorPreferredValues has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function getIndicatorPreferredValues(tag, indicatorNumber, config) {
    const cands = getIndicatorPreferredValuesForGivenTag(tag, indicatorNumber, config);
    // More complex systems where multiple indicators have same priority are objects.
    // Example: field 506 might return {"0": 1, "1": 1, " ": 2}
    // Here indicator values '0' and '1' share top priority 1, and '#' is of lesser importance, namely 2.

Function default has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export default function () {

  return {
    description, validate, fix
  };

Function default has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export default function () {
  const PATTERN = Object.keys(MAP_CONVERSION).reduce((result, key, index, list) => index === list.length - 1 ? new RegExp(`${result}${key})`, 'u') : `${result}${key}|`, '(');

  return {
    description: 'Unicode decomposer',

Function default has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export default function () {
  return {
    description: 'Handles subfields that contains non-breaking space character',
    validate,
    fix

Function default has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export default function () {

  // NB! We should and could handle ISNIs here as well.
  return {
    description: 'Normalizes identifiers such as subfield $0 values',

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  function trimExtent(value) {
    return value.replace(/\([^)]*\)/gu, '').replace(/\[[^\]*]\]/gu, '').replace(/[0-9]/gu, '').replace(/^ +/gu, '').replace(/[ :;+]+$/gu, '').replace(/  +/gu, ' ');
  }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

function normalizeNonFilingIndicator2(field, languages = []) {
  if (!hasNonFilingIndicator2(field) || !modifiableIndicatorValue(field.ind2)) {
    return;
  }

• Read up
  Read up