NatLibFi/marc-record-validators-melinda

Similar blocks of code found in 9 locations. Consider refactoring.

Open

      const recordInvalid = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '567',

• Read up
  Read up

Similar blocks of code found in 9 locations. Consider refactoring.

Open

      const recordValidWithoutY = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '242',

• Read up
  Read up

Function validate has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function validate(record) {
    const fields = getRelevantFields(record);

    if (fields.length === 0) {
      return {valid: true};

Function default has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export default function () {

  return {
    description: 'Normalizes indicator values',
    validate, fix

Function optionalSubfieldComparison has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function optionalSubfieldComparison(originalBaseField, originalSourceField, keySubfieldsAsString) {
  // Here "optional subfield" means a subfield, that needs not to be present, but if present, it must be identical...
  // (Think of a better name...)
  // We use clones here, since these changes done below are not intented to appear on the actual records.
  const field1 = cloneAndNormalizeFieldForComparison(originalBaseField);

Function removeDuplicateSubfield8Chains has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function removeDuplicateSubfield8Chains(record, fix = true) {

  // Seen $8 subsfields in various fields:
  // 161 700
  // 17 710

Function deriveInferiorChains has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function deriveInferiorChains(fields, record) {
  //nvdebug(`======= GOT ${fields.length} FIELDS TO CHAINIFY`);
  const hash = {};

  fields.forEach(f => fieldToChainToDeletables(f));

Function recordResetSubfield6OccurrenceNumbers has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export function recordResetSubfield6OccurrenceNumbers(record) { // Remove gaps
  /* eslint-disable */
  let currentInt = 1;
  let oldtoNewCache = {};

Function default has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

export default function () {

  return {
    // Fixes MELINDA-8740
    description: 'Normalize qualifying information (020$q, 015$q, 024$q, 028$q)',

Function swapESubfields has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function swapESubfields(field) {
  if (!field.subfields) {
    return;
  }

Similar blocks of code found in 10 locations. Consider refactoring.

Open

      try {
        await validatorFactory(config);
      } catch (error) {
        expect(error).to.be.an('error').with.property('message', 'Configuration not valid - subfield: /9/,/^(?!FENNI<KEEP>).*$/ not object');
      }

• Read up
  Read up

Similar blocks of code found in 10 locations. Consider refactoring.

Open

      try {
        await validatorFactory(config);
      } catch (error) {
        expect(error).to.be.an('error').with.property('message', 'Configuration not valid - missing mandatory element: code');
      }

• Read up
  Read up

Similar blocks of code found in 10 locations. Consider refactoring.

Open

      try {
        await validatorFactory(config);
      } catch (error) {
        expect(error).to.be.an('error').with.property('message', 'Configuration not valid - invalid data type for: tag');
      }

• Read up
  Read up

Similar blocks of code found in 10 locations. Consider refactoring.

Open

      try {
        await validatorFactory(config);
      } catch (error) {
        expect(error).to.be.an('error').with.property('message', 'Configuration not valid - excluded element');
      }

• Read up
  Read up

Similar blocks of code found in 10 locations. Consider refactoring.

Open

      try {
        await validatorFactory(config);
      } catch (error) {
        expect(error).to.be.an('error').with.property('message', 'Configuration not valid - subfield: /9/ not object');
      }

• Read up
  Read up

Similar blocks of code found in 10 locations. Consider refactoring.

Open

      try {
        await validatorFactory(config);
      } catch (error) {
        expect(error).to.be.an('error').with.property('message', 'Configuration not valid - unidentified value: unidentified');
      }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const messages = nonValidFields.flatMap(({tag, subfields}) => subfields.map(sf => `Field ${tag} subfield $${sf.code} contains non-breaking space character(s)`));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const messages = nonValidFields.flatMap(({tag, subfields}) => subfields.map(sf => `Field ${tag} subfield $${sf.code} ends with whitespace`));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function nvdebugFieldArray(fields, prefix = '  ', func = undefined) {
  fields.forEach(field => nvdebug(`${prefix}${fieldToString(field)}`, func));
}

• Read up
  Read up

Similar blocks of code found in 10 locations. Consider refactoring.

Open

      try {
        await validatorFactory(config);
      } catch (error) {
        expect(error).to.be.an('error').with.property('message', 'Configuration not valid - missing mandatory element: tag');
      }

• Read up
  Read up