Showing 20 of 20 total issues
Function factory has 355 lines of code (exceeds 25 allowed). Consider refactoring. Open
function factory(Promise, Object, Array, shim_array, utils, loggerFactory, resultFormatterFactory, recordStoreFactory, relatedRecordsRetrievedHookFactory, relatedRecordsMatchedHookFactory)
{
'use strict';
Function exports has 348 lines of code (exceeds 25 allowed). Consider refactoring. Open
var exports = function(modules, script_processor)
{
/**
* @constantFunction processRecordSet has 169 lines of code (exceeds 25 allowed). Consider refactoring. Open
function processRecordSet(total_results)
{
var fn_related_records_pipeline;
Function factory has 160 lines of code (exceeds 25 allowed). Consider refactoring. Open
function factory(Promise, Object, shim_array, utils, loggerFactory, recordStoreFactory, filterProcessorFactory, preprocessProcessorFactory, matchProcessorFactory, mergeProcessorFactory, loadProcessorFactory)
{
'use strict';
Function exports has 136 lines of code (exceeds 25 allowed). Consider refactoring. Open
var exports = function(modules)
{
var modules_run, loggers, initialized;
File create-main.js has 389 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
*
* @licstart The following is the entire license notice for the JavaScript code in this file.
*
* Load records into a data store while filtering, preprocessing, matching & merging them in the processConsider simplifying this complex logical expression. Open
if (!modules.hasOwnProperty('recordSet')) {
throw new Error('Record set module is mandatory');
} else {
/**
* @callback loadRecordsFunction factory has 100 lines of code (exceeds 25 allowed). Consider refactoring. Open
function factory(Object)
{
'use strict';
Function processRecord has 98 lines of code (exceeds 25 allowed). Consider refactoring. Open
function processRecord(state, target_step, options, exchange_data)
{
var steps = utils.PROCESSING_STEPS.slice(
state.step ? utils.PROCESSING_STEPS.indexOf(state.step) + 1 : 0,
utils.PROCESSING_STEPS.indexOf(target_step) + 1Function createFinalResults has 85 lines of code (exceeds 25 allowed). Consider refactoring. Open
function createFinalResults(result_sets)
{
var results, final_results;
Function factory has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
function factory(Object)
{
'use strict';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function buildRelatedRecordsPipeline has 69 lines of code (exceeds 25 allowed). Consider refactoring. Open
function buildRelatedRecordsPipeline(target)
{
var target_index = utils.PROCESSING_STEPS.indexOf(target),
match_index = utils.PROCESSING_STEPS.indexOf('match');Similar blocks of code found in 2 locations. Consider refactoring. Open
return Object.getOwnPropertyNames(state).filter(function(name) {
return name !== 'step';
}).reduce(function(product, name) {
return Object.defineProperty(product, name, {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 85.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
}) : Object.keys(error).filter(function(key) {
return key !== 'recordStore';
}).reduce(function(result, key) {
return Object.defineProperty(result, key, {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 85.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function iterate has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
function iterate(steps, state)
{
var fn_run_processor,
step = steps.shift();
Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function(config) {
config.set({
singleRun: true,
frameworks: ['mocha', 'requirejs'],
browsers: ['PhantomJS'],Function factory has 11 arguments (exceeds 4 allowed). Consider refactoring. Open
function factory(Promise, Object, shim_array, utils, loggerFactory, recordStoreFactory, filterProcessorFactory, preprocessProcessorFactory, matchProcessorFactory, mergeProcessorFactory, loadProcessorFactory)Function factory has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
function factory(Promise, Object, Array, shim_array, utils, loggerFactory, resultFormatterFactory, recordStoreFactory, relatedRecordsRetrievedHookFactory, relatedRecordsMatchedHookFactory)Function initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
function initialize(modules_run, options)
{
if (modules_run && loggers) {
return {
modules: modules_run,Function process has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
function process(records, target)
{
return new Promise(function(resolveCallback, rejectCallback) {
var results = [];