Sign upLogin

NatLibFi/record-loader

View on GitHub
Star
lib/create-main.js

Summary

Maintainability
F
6 days
Test Coverage

Function factory has 355 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function factory(Promise, Object, Array, shim_array, utils, loggerFactory, resultFormatterFactory, recordStoreFactory, relatedRecordsRetrievedHookFactory, relatedRecordsMatchedHookFactory)
{

  'use strict';
Severity: Major
Found in lib/create-main.js - About 1 day to fix

    Function exports has 348 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var exports = function(modules, script_processor)
    {
      
      /**
       * @constant
    Severity: Major
    Found in lib/create-main.js - About 1 day to fix

      Function processRecordSet has 169 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  function processRecordSet(total_results)
            {
              
              var fn_related_records_pipeline;
      Severity: Major
      Found in lib/create-main.js - About 6 hrs to fix

        File create-main.js has 389 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /**
 *
 * @licstart  The following is the entire license notice for the JavaScript code in this file. 
 *
 * Load records into a data store while filtering, preprocessing, matching & merging them in the process
        Severity: Minor
        Found in lib/create-main.js - About 5 hrs to fix

          Consider simplifying this complex logical expression.
          Open

                if (!modules.hasOwnProperty('recordSet')) {
        throw new Error('Record set module is mandatory');
      } else {
        /**
         * @callback loadRecords
          Severity: Critical
          Found in lib/create-main.js - About 4 hrs to fix

            Function createFinalResults has 85 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        function createFinalResults(result_sets)
            {
              
              var results, final_results;
            Severity: Major
            Found in lib/create-main.js - About 3 hrs to fix

              Function buildRelatedRecordsPipeline has 69 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                            function buildRelatedRecordsPipeline(target)
              {

                var target_index = utils.PROCESSING_STEPS.indexOf(target),
                match_index = utils.PROCESSING_STEPS.indexOf('match');
              Severity: Major
              Found in lib/create-main.js - About 2 hrs to fix

                Function factory has 10 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function factory(Promise, Object, Array, shim_array, utils, loggerFactory, resultFormatterFactory, recordStoreFactory, relatedRecordsRetrievedHookFactory, relatedRecordsMatchedHookFactory)
                Severity: Major
                Found in lib/create-main.js - About 1 hr to fix

                  Function process has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                                  function process(records, target)
                {
                  return new Promise(function(resolveCallback, rejectCallback) {

                    var results = [];
                  Severity: Minor
                  Found in lib/create-main.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                      }) : Object.keys(error).filter(function(key) {
                    return key !== 'recordStore';
                  }).reduce(function(result, key) {
                    
                    return Object.defineProperty(result, key, {
                    Severity: Major
                    Found in lib/create-main.js and 1 other location - About 2 hrs to fix
                    lib/create-processor-factory.js on lines 173..184

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 85.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status