Sign upLogin

NatLibFi/record-loader

View on GitHub
Star
lib/create-processor-factory.js

Summary

Maintainability
D
2 days
Test Coverage

Function factory has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function factory(Promise, Object, shim_array, utils, loggerFactory, recordStoreFactory, filterProcessorFactory, preprocessProcessorFactory, matchProcessorFactory, mergeProcessorFactory, loadProcessorFactory)
{

  'use strict';
Severity: Major
Found in lib/create-processor-factory.js - About 6 hrs to fix

    Function exports has 136 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var exports = function(modules)
    {
      
      var modules_run, loggers, initialized;
    Severity: Major
    Found in lib/create-processor-factory.js - About 5 hrs to fix

      Function processRecord has 98 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            function processRecord(state, target_step, options, exchange_data)
      {
        var steps = utils.PROCESSING_STEPS.slice(
          state.step ? utils.PROCESSING_STEPS.indexOf(state.step) + 1 : 0,
          utils.PROCESSING_STEPS.indexOf(target_step) + 1
      Severity: Major
      Found in lib/create-processor-factory.js - About 3 hrs to fix

        Function iterate has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function iterate(steps, state)
        {
          var fn_run_processor,
          step = steps.shift();
        Severity: Minor
        Found in lib/create-processor-factory.js - About 1 hr to fix

          Function factory has 11 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function factory(Promise, Object, shim_array, utils, loggerFactory, recordStoreFactory, filterProcessorFactory, preprocessProcessorFactory, matchProcessorFactory, mergeProcessorFactory, loadProcessorFactory)
          Severity: Major
          Found in lib/create-processor-factory.js - About 1 hr to fix

            Function initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  function initialize(modules_run, options)
      {
        if (modules_run && loggers) {
          return {
            modules: modules_run,
            Severity: Minor
            Found in lib/create-processor-factory.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        return Object.getOwnPropertyNames(state).filter(function(name) {
            return name !== 'step';
          }).reduce(function(product, name) {

            return Object.defineProperty(product, name, {
              Severity: Major
              Found in lib/create-processor-factory.js and 1 other location - About 2 hrs to fix
              lib/create-main.js on lines 373..384

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 85.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status