Sign upLogin

NaturalIntelligence/Stubmatic

View on GitHub
Star
lib/RequestResolver.js

Summary

Maintainability
D
2 days
Test Coverage

Function matchParamters has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

function matchParamters(http_request, mapped_request, param_name){
    var clips = [];
    clips[0] = "N/A";
    if( !http_request[param_name]){
        if( mapped_request[param_name] ){
Severity: Minor
Found in lib/RequestResolver.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function matchAndCapture has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

function matchAndCapture(mapped_request, http_request){
    var matched = {}, i=0;

    if(Array.isArray(mapped_request.method)){
        if(mapped_request.method.indexOf(http_request.method) === -1) return;
Severity: Minor
Found in lib/RequestResolver.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    parse(http_request, mappings, dataTables){
        for(var i=0;i<mappings.length;i++){
            var entry = util.clone(mappings[i]);
            var matched = matchAndCapture(entry.request, http_request);
            if(matched){//if nothing matches in current mapping, check for other matching
Severity: Minor
Found in lib/RequestResolver.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function matchParamters has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function matchParamters(http_request, mapped_request, param_name){
    var clips = [];
    clips[0] = "N/A";
    if( !http_request[param_name]){
        if( mapped_request[param_name] ){
Severity: Minor
Found in lib/RequestResolver.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                    if(!matches) return;
    Severity: Major
    Found in lib/RequestResolver.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if(matches && matches.length > 1){
                    matches = matches.slice(1);
                    clips = clips.concat(matches);
                }
      Severity: Major
      Found in lib/RequestResolver.js - About 45 mins to fix

        Function resolveDBSetKey has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        var resolveDBSetKey = function (table, tables){
    if(table.key){
        var row = tables[table.name].get(table.key);
        if(row){
            return table.key;
        Severity: Minor
        Found in lib/RequestResolver.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                    else            return;
        Severity: Major
        Found in lib/RequestResolver.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return;
          Severity: Major
          Found in lib/RequestResolver.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            if(!matches) return;
            Severity: Major
            Found in lib/RequestResolver.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return matched;
              Severity: Major
              Found in lib/RequestResolver.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return clips;
                Severity: Major
                Found in lib/RequestResolver.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  var resolveDBSetKey = function (table, tables){
    if(table.key){
        var row = tables[table.name].get(table.key);
        if(row){
            return table.key;
                  Severity: Major
                  Found in lib/RequestResolver.js and 1 other location - About 7 hrs to fix
                  lib/expressions/dataTableExpression.js on lines 52..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 193.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status