NodeBB/NodeBB

View on GitHub

Showing 443 of 552 total issues

Function exports has a Cognitive Complexity of 71 (exceeds 10 allowed). Consider refactoring.
Open

module.exports = function (Categories) {
    Categories.getCategoryTopics = async function (data) {
        let results = await plugins.hooks.fire('filter:category.topics.prepare', data);
        const tids = await Categories.getTopicIds(results);
        let topicsData = await topics.getTopicsByTids(tids, data.uid);
Severity: Minor
Found in src/categories/topics.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 308 lines of code (exceeds 75 allowed). Consider refactoring.
Open

module.exports = function (utils, Benchpress, relative_path) {
    Benchpress.setGlobal('true', true);
    Benchpress.setGlobal('false', false);
    const oneDayInMs = 24 * 60 * 60 * 1000;

Severity: Major
Found in public/src/modules/helpers.common.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 69 (exceeds 10 allowed). Consider refactoring.
    Open

    module.exports = function (Topics) {
        Topics.getSortedTopics = async function (params) {
            const data = {
                nextStart: 0,
                topicCount: 0,
    Severity: Minor
    Found in src/topics/sorted.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exports has a Cognitive Complexity of 69 (exceeds 10 allowed). Consider refactoring.
    Open

    module.exports = function (module) {
        const helpers = require('./helpers');
    
        const cache = require('../cache').create('redis');
    
    
    Severity: Minor
    Found in src/database/redis/hash.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exports has a Cognitive Complexity of 69 (exceeds 10 allowed). Consider refactoring.
    Open

    module.exports = function (User) {
        const fieldWhitelist = [
            'uid', 'username', 'userslug', 'email', 'email:confirmed', 'joindate',
            'lastonline', 'picture', 'icon:bgColor', 'fullname', 'location', 'birthday', 'website',
            'aboutme', 'signature', 'uploadedpicture', 'profileviews', 'reputation',
    Severity: Minor
    Found in src/user/data.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function email has a Cognitive Complexity of 67 (exceeds 10 allowed). Consider refactoring.
    Open

    Interstitials.email = async (data) => {
        if (!data.userData) {
            throw new Error('[[error:invalid-data]]');
        }
        if (!data.userData.updateEmail) {
    Severity: Minor
    Found in src/user/interstitials.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exports has 285 lines of code (exceeds 75 allowed). Consider refactoring.
    Open

    module.exports = function (module) {
        const utils = require('../../utils');
        const helpers = require('./helpers');
        const dbHelpers = require('../helpers');
    
    
    Severity: Major
    Found in src/database/redis/sorted.js - About 1 day to fix

      Function exports has a Cognitive Complexity of 64 (exceeds 10 allowed). Consider refactoring.
      Open

      module.exports = function (module) {
          module.sortedSetIntersectCard = async function (keys) {
              if (!Array.isArray(keys) || !keys.length) {
                  return 0;
              }
      Severity: Minor
      Found in src/database/mongo/sorted/intersect.js - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 280 lines of code (exceeds 75 allowed). Consider refactoring.
      Open

      module.exports = function (User) {
          const fieldWhitelist = [
              'uid', 'username', 'userslug', 'email', 'email:confirmed', 'joindate',
              'lastonline', 'picture', 'icon:bgColor', 'fullname', 'location', 'birthday', 'website',
              'aboutme', 'signature', 'uploadedpicture', 'profileviews', 'reputation',
      Severity: Major
      Found in src/user/data.js - About 1 day to fix

        Function exports has 279 lines of code (exceeds 75 allowed). Consider refactoring.
        Open

        module.exports = function (User) {
            User.updateProfile = async function (uid, data, extraFields) {
                let fields = [
                    'username', 'email', 'fullname', 'website', 'location',
                    'groupTitle', 'birthday', 'signature', 'aboutme',
        Severity: Major
        Found in src/user/profile.js - About 1 day to fix

          Function exports has a Cognitive Complexity of 58 (exceeds 10 allowed). Consider refactoring.
          Open

          module.exports = function (User) {
              User.create = async function (data) {
                  data.username = data.username.trim();
                  data.userslug = slugify(data.username);
                  if (data.email !== undefined) {
          Severity: Minor
          Found in src/user/create.js - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has 245 lines of code (exceeds 75 allowed). Consider refactoring.
          Open

          module.exports = function (Topics) {
              Topics.create = async function (data) {
                  // This is an internal method, consider using Topics.post instead
                  const timestamp = data.timestamp || Date.now();
          
          
          Severity: Major
          Found in src/topics/create.js - About 7 hrs to fix

            Function exports has 244 lines of code (exceeds 75 allowed). Consider refactoring.
            Open

            module.exports = function (Posts) {
                const votesInProgress = {};
            
                Posts.upvote = async function (pid, uid) {
                    if (meta.config['reputation:disabled']) {
            Severity: Major
            Found in src/posts/votes.js - About 7 hrs to fix

              Function exports has a Cognitive Complexity of 55 (exceeds 10 allowed). Consider refactoring.
              Open

              module.exports = function (module) {
                  const _ = require('lodash');
                  const helpers = require('./helpers');
              
                  module.setAdd = async function (key, value) {
              Severity: Minor
              Found in src/database/mongo/sets.js - About 7 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function exports has 243 lines of code (exceeds 75 allowed). Consider refactoring.
              Open

              module.exports = function (Groups) {
                  Groups.update = async function (groupName, values) {
                      const exists = await db.exists(`group:${groupName}`);
                      if (!exists) {
                          throw new Error('[[error:no-group]]');
              Severity: Major
              Found in src/groups/update.js - About 7 hrs to fix

                Function setupGraphs has 239 lines of code (exceeds 75 allowed). Consider refactoring.
                Open

                function setupGraphs(callback) {
                    callback = callback || function () {};
                    const trafficCanvas = document.getElementById('analytics-traffic');
                    const registeredCanvas = document.getElementById('analytics-registered');
                    const presenceCanvas = document.getElementById('analytics-presence');
                Severity: Major
                Found in public/src/admin/dashboard.js - About 7 hrs to fix

                  Function exports has 237 lines of code (exceeds 75 allowed). Consider refactoring.
                  Open

                  module.exports = function (Topics) {
                      const topicTools = {};
                      Topics.tools = topicTools;
                  
                      topicTools.delete = async function (tid, uid) {
                  Severity: Major
                  Found in src/topics/tools.js - About 7 hrs to fix

                    Function checkUpgrade has 237 lines of code (exceeds 75 allowed). Consider refactoring.
                    Open

                    async function checkUpgrade(client) {
                        const res = await client.query(`
                    SELECT EXISTS(SELECT *
                                    FROM "information_schema"."columns"
                                   WHERE "table_schema" = 'public'
                    Severity: Major
                    Found in src/database/postgres.js - About 7 hrs to fix

                      Function exports has 235 lines of code (exceeds 75 allowed). Consider refactoring.
                      Open

                      module.exports = function (Topics) {
                          Topics.getSortedTopics = async function (params) {
                              const data = {
                                  nextStart: 0,
                                  topicCount: 0,
                      Severity: Major
                      Found in src/topics/sorted.js - About 7 hrs to fix

                        Function exports has 234 lines of code (exceeds 75 allowed). Consider refactoring.
                        Open

                        module.exports = function (Posts) {
                            Posts.getUserInfoForPosts = async function (uids, uid) {
                                const [userData, userSettings, signatureUids] = await Promise.all([
                                    getUserData(uids, uid),
                                    user.getMultipleUserSettings(uids),
                        Severity: Major
                        Found in src/posts/user.js - About 7 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language