Sign upLogin

NodeBB/NodeBB

View on GitHub
Star

Showing 536 of 552 total issues

Function exports has 106 lines of code (exceeds 75 allowed). Consider refactoring.
Open

module.exports = function (Messaging) {
    Messaging.setUserNotificationSetting = async (uid, roomId, value) => {
        if (parseInt(value, 10) === -1) {
            // go back to default
            return await db.deleteObjectField(`chat:room:${roomId}:notification:settings`, uid);
Severity: Major
Found in src/messaging/notifications.js - About 2 hrs to fix

    Function init has 105 lines of code (exceeds 75 allowed). Consider refactoring.
    Open

        CategoryTools.init = function () {
        topicSelect.init(updateDropdownOptions);

        handlePinnedTopicSort();
    Severity: Major
    Found in public/src/client/category/tools.js - About 2 hrs to fix

      Function exports has 105 lines of code (exceeds 75 allowed). Consider refactoring.
      Open

      module.exports = function (opts) {
    const TTLCache = require('@isaacs/ttlcache');
    const pubsub = require('../pubsub');

    const ttlCache = new TTLCache(opts);
      Severity: Major
      Found in src/cache/ttl.js - About 2 hrs to fix

        Function loadConfig has 104 lines of code (exceeds 75 allowed). Consider refactoring.
        Open

        apiController.loadConfig = async function (req) {
    const config = {
        relative_path,
        upload_url,
        asset_base_url,
        Severity: Major
        Found in src/controllers/api.js - About 2 hrs to fix

          Function exports has a Cognitive Complexity of 21 (exceeds 10 allowed). Consider refactoring.
          Open

          module.exports = function (module) {
    const helpers = require('../helpers');

    module.sortedSetRemove = async function (key, value) {
        if (!key) {
          Severity: Minor
          Found in src/database/postgres/sorted/remove.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has a Cognitive Complexity of 21 (exceeds 10 allowed). Consider refactoring.
          Open

          module.exports = function (Posts) {
    Posts.getPostsFromSet = async function (set, start, stop, uid, reverse) {
        const pids = await Posts.getPidsFromSet(set, start, stop, reverse);
        const posts = await Posts.getPostsByPids(pids, uid);
        return await user.blocks.filter(uid, posts);
          Severity: Minor
          Found in src/posts/topics.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has a Cognitive Complexity of 21 (exceeds 10 allowed). Consider refactoring.
          Open

          module.exports = function (User) {
    User.follow = async function (uid, followuid) {
        await toggleFollow('follow', uid, followuid);
    };
          Severity: Minor
          Found in src/user/follow.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function checkSetupFlagEnv has a Cognitive Complexity of 21 (exceeds 10 allowed). Consider refactoring.
          Open

          function checkSetupFlagEnv() {
    let setupVal = install.values;

    const envConfMap = {
        CONFIG: 'config',
          Severity: Minor
          Found in src/install.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has 102 lines of code (exceeds 75 allowed). Consider refactoring.
          Open

          module.exports = function (User) {
    User.bans = {};

    User.bans.ban = async function (uid, until, reason) {
        // "until" (optional) is unix timestamp in milliseconds
          Severity: Major
          Found in src/user/bans.js - About 2 hrs to fix

            File ajaxify.js has 501 lines of code (exceeds 500 allowed). Consider refactoring.
            Open

            'use strict';

const benchpress = require('benchpressjs');
const translator = require('./modules/translator');
const alerts = require('./modules/alerts');
            Severity: Major
            Found in public/src/ajaxify.js - About 2 hrs to fix

              Function init has 100 lines of code (exceeds 75 allowed). Consider refactoring.
              Open

                  QuickReply.init = function () {
        const element = components.get('topic/quickreply/text');
        const qrDraftId = `qr:draft:tid:${ajaxify.data.tid}`;
        const data = {
            element: element,
              Severity: Major
              Found in public/src/modules/quickreply.js - About 2 hrs to fix

                Function init has 100 lines of code (exceeds 75 allowed). Consider refactoring.
                Open

                    AdminsMods.init = function () {
        autocomplete.user($('#admin-search'), function (ev, ui) {
            socket.emit('admin.user.makeAdmins', [ui.item.user.uid], function (err) {
                if (err) {
                    return alerts.error(err);
                Severity: Major
                Found in public/src/admin/manage/admins-mods.js - About 2 hrs to fix

                  Function getUserDataByUserSlug has 99 lines of code (exceeds 75 allowed). Consider refactoring.
                  Open

                  helpers.getUserDataByUserSlug = async function (userslug, callerUID, query = {}) {
    const uid = await user.getUidByUserslug(userslug);
    if (!uid) {
        return null;
    }
                  Severity: Major
                  Found in src/controllers/accounts/helpers.js - About 1 hr to fix

                    Function getTopic has 99 lines of code (exceeds 75 allowed). Consider refactoring.
                    Open

                    topicsController.get = async function getTopic(req, res, next) {
    const tid = req.params.topic_id;
    if (
        (req.params.post_index && !utils.isNumber(req.params.post_index) && req.params.post_index !== 'unread') ||
        !utils.isNumber(tid)
                    Severity: Major
                    Found in src/controllers/topics.js - About 1 hr to fix

                      Function fireStaticHook has a Cognitive Complexity of 20 (exceeds 10 allowed). Consider refactoring.
                      Open

                      async function fireStaticHook(hook, hookList, params) {
    if (!Array.isArray(hookList) || !hookList.length) {
        return;
    }
    // don't bubble errors from these hooks, so bad plugins don't stop startup
                      Severity: Minor
                      Found in src/plugins/hooks.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function search has a Cognitive Complexity of 20 (exceeds 10 allowed). Consider refactoring.
                      Open

                      searchController.search = async function (req, res, next) {
    if (!plugins.hooks.hasListeners('filter:search.query')) {
        return next();
    }
    const page = Math.max(1, parseInt(req.query.page, 10)) || 1;
                      Severity: Minor
                      Found in src/controllers/search.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                              if (Array.isArray(key)) {
            const batch = module.client.batch();
            key.forEach(k => batch.hmset(k, data));
            await helpers.execBatch(batch);
        } else {
                      Severity: Major
                      Found in src/database/redis/hash.js and 2 other locations - About 1 hr to fix
                      src/database/redis/hash.js on lines 187..193
                      src/database/redis/sorted/remove.js on lines 19..25

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 92.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                              if (Array.isArray(key)) {
            const batch = module.client.batch();
            key.forEach(k => batch.hdel(k, fields));
            await helpers.execBatch(batch);
        } else {
                      Severity: Major
                      Found in src/database/redis/hash.js and 2 other locations - About 1 hr to fix
                      src/database/redis/hash.js on lines 28..34
                      src/database/redis/sorted/remove.js on lines 19..25

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 92.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                              if (Array.isArray(key)) {
            const batch = module.client.batch();
            key.forEach(k => batch.zrem(k, value));
            await helpers.execBatch(batch);
        } else {
                      Severity: Major
                      Found in src/database/redis/sorted/remove.js and 2 other locations - About 1 hr to fix
                      src/database/redis/hash.js on lines 28..34
                      src/database/redis/hash.js on lines 187..193

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 92.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function merge has 96 lines of code (exceeds 75 allowed). Consider refactoring.
                      Open

                      Notifications.merge = async function (notifications) {
    // When passed a set of notification objects, merge any that can be merged
    const mergeIds = [
        'notifications:upvoted-your-post-in',
        'notifications:user-started-following-you',
                      Severity: Major
                      Found in src/notifications.js - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language