NodeBB/NodeBB

View on GitHub
public/src/client/topic/postTools.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function addPostHandlers has 143 lines of code (exceeds 75 allowed). Consider refactoring.
Open

    function addPostHandlers(tid) {
        const postContainer = components.get('topic');

        handleSelectionTooltip();

Severity: Major
Found in public/src/client/topic/postTools.js - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        if (numSeconds) {
                            msg = '[[error:' + languageKey + '-minutes-seconds, ' + numMinutes + ', ' + numSeconds + ']]';
                        } else {
                            msg = '[[error:' + languageKey + '-minutes, ' + numMinutes + ']]';
                        }
    Severity: Major
    Found in public/src/client/topic/postTools.js - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      } else if (numMinutes) {
                          if (numSeconds) {
                              msg = '[[error:' + languageKey + '-minutes-seconds, ' + numMinutes + ', ' + numSeconds + ']]';
                          } else {
                              msg = '[[error:' + languageKey + '-minutes, ' + numMinutes + ']]';
      Severity: Major
      Found in public/src/client/topic/postTools.js and 2 other locations - About 40 mins to fix
      public/src/client/topic/postTools.js on lines 205..223
      public/src/client/topic/postTools.js on lines 211..223

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      if (numDays) {
                          if (numHours) {
                              msg = '[[error:' + languageKey + '-days-hours, ' + numDays + ', ' + numHours + ']]';
                          } else {
                              msg = '[[error:' + languageKey + '-days, ' + numDays + ']]';
      Severity: Major
      Found in public/src/client/topic/postTools.js and 2 other locations - About 40 mins to fix
      public/src/client/topic/postTools.js on lines 211..223
      public/src/client/topic/postTools.js on lines 217..223

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      } else if (numHours) {
                          if (numMinutes) {
                              msg = '[[error:' + languageKey + '-hours-minutes, ' + numHours + ', ' + numMinutes + ']]';
                          } else {
                              msg = '[[error:' + languageKey + '-hours, ' + numHours + ']]';
      Severity: Major
      Found in public/src/client/topic/postTools.js and 2 other locations - About 40 mins to fix
      public/src/client/topic/postTools.js on lines 205..223
      public/src/client/topic/postTools.js on lines 217..223

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status