NodeRedis/node-redis-parser

View on GitHub

Showing 15 of 15 total issues

File parser.js has 370 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'

const Buffer = require('buffer').Buffer
const StringDecoder = require('string_decoder').StringDecoder
const decoder = new StringDecoder()
Severity: Minor
Found in lib/parser.js - About 4 hrs to fix

    Function execute has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

      execute (buffer) {
        if (this.buffer === null) {
          this.buffer = buffer
          this.offset = 0
        } else if (this.bigStrSize === 0) {
    Severity: Minor
    Found in lib/parser.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function execute has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      execute (buffer) {
        if (this.buffer === null) {
          this.buffer = buffer
          this.offset = 0
        } else if (this.bigStrSize === 0) {
    Severity: Major
    Found in lib/parser.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      suite.add('JS PARSER: $ 4mb bulk string', function () {
        parser.execute(startBigBuffer)
        for (var i = 0; i < 64; i++) {
          parser.execute(chunks[i])
        }
      Severity: Major
      Found in benchmark/index.js and 1 other location - About 2 hrs to fix
      benchmark/index.js on lines 114..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      suite.add('JS PARSER BUF: $ 4mb bulk string', function () {
        parserBuffer.execute(startBigBuffer)
        for (var i = 0; i < 64; i++) {
          parserBuffer.execute(chunks[i])
        }
      Severity: Major
      Found in benchmark/index.js and 1 other location - About 2 hrs to fix
      benchmark/index.js on lines 106..112

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      suite.add('JS PARSER BUF: $ multiple chunks in a bulk string', function () {
        parserBuffer.execute(startBuffer)
        parserBuffer.execute(chunkBuffer)
        parserBuffer.execute(chunkBuffer)
        parserBuffer.execute(chunkBuffer)
      Severity: Major
      Found in benchmark/index.js and 1 other location - About 1 hr to fix
      benchmark/index.js on lines 76..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      suite.add('JS PARSER: $ multiple chunks in a bulk string', function () {
        parser.execute(startBuffer)
        parser.execute(chunkBuffer)
        parser.execute(chunkBuffer)
        parser.execute(chunkBuffer)
      Severity: Major
      Found in benchmark/index.js and 1 other location - About 1 hr to fix
      benchmark/index.js on lines 84..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function parseStringNumbers has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function parseStringNumbers (parser) {
        const length = parser.buffer.length - 1
        var offset = parser.offset
        var number = 0
        var res = ''
      Severity: Minor
      Found in lib/parser.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      suite.add('JS PARSER: * big nested array', function () {
        for (var i = 0; i < bigArrayChunks.length; i++) {
          parser.execute(bigArrayChunks[i])
        }
      })
      Severity: Major
      Found in benchmark/index.js and 1 other location - About 1 hr to fix
      benchmark/index.js on lines 170..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      suite.add('JS PARSER BUF: * big nested array', function () {
        for (var i = 0; i < bigArrayChunks.length; i++) {
          parserBuffer.execute(bigArrayChunks[i])
        }
      })
      Severity: Major
      Found in benchmark/index.js and 1 other location - About 1 hr to fix
      benchmark/index.js on lines 164..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function parseArrayElements has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function parseArrayElements (parser, responses, i) {
        const bufferLength = parser.buffer.length
        while (i < responses.length) {
          const offset = parser.offset
          if (parser.offset >= bufferLength) {
      Severity: Minor
      Found in lib/parser.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function decreaseBufferPool has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function decreaseBufferPool () {
        if (bufferPool.length > 50 * 1024) {
          if (counter === 1 || notDecreased > counter * 2) {
            const minSliceLen = Math.floor(bufferPool.length / 10)
            const sliceLength = minSliceLen < bufferOffset
      Severity: Minor
      Found in lib/parser.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function resizeBuffer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function resizeBuffer (length) {
        if (bufferPool.length < length + bufferOffset) {
          const multiplier = length > 1024 * 1024 * 75 ? 2 : 3
          if (bufferOffset > 1024 * 1024 * 111) {
            bufferOffset = 1024 * 1024 * 50
      Severity: Minor
      Found in lib/parser.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

        return parser.buffer.toString('utf8', start, offset)
      Severity: Major
      Found in lib/parser.js - About 30 mins to fix

        Function parseSimpleString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function parseSimpleString (parser) {
          const start = parser.offset
          const buffer = parser.buffer
          const length = buffer.length - 1
          var offset = start
        Severity: Minor
        Found in lib/parser.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language