NullVoxPopuli/skinny_controllers

View on GitHub
lib/skinny_controllers/lookup.rb

Summary

Maintainability
A
0 mins
Test Coverage

Add an empty line after magic comments. (https://github.com/bbatsov/ruby-style-guide#separate-magic-comments-from-code)
Open

module SkinnyControllers
Severity: Minor
Found in lib/skinny_controllers/lookup.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Useless assignment to variable - operation_parts. Did you mean operation_class? (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
Open

        operation_parts = operation_name.split(SkinnyControllers.operations_suffix)
Severity: Minor
Found in lib/skinny_controllers/lookup.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

There are no issues that match your filters.

Category
Status