Sign upLogin

OCA/l10n-italy

View on GitHub
Star
l10n_it_bill_of_entry/account_invoice.py

Summary

Maintainability
D
2 days
Test Coverage

Function action_move_create has a Cognitive Complexity of 87 (exceeds 5 allowed). Consider refactoring.
Open

    def action_move_create(self, cr, uid, ids, context=None):
        res = super(account_invoice,self).action_move_create(cr, uid, ids, context=context)
        move_obj = self.pool.get('account.move')
        move_line_obj = self.pool.get('account.move.line')
        period_obj = self.pool.get('account.period')
Severity: Minor
Found in l10n_it_bill_of_entry/account_invoice.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if tax_code_id:
                            line_vals['tax_code_id'] = tax_code_id
                            line_vals['tax_amount'] = boe_line.price_subtotal
                        move_lines.append((0, 0, line_vals))
Severity: Major
Found in l10n_it_bill_of_entry/account_invoice.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if move_line.account_id.id == bill_of_entry.account_id.id:
                            reconcile_ids.append(move_line.id)
                            for boe_move_line in bill_of_entry.move_id.line_id:
                                if boe_move_line.account_id.id == bill_of_entry.account_id.id:
                                    reconcile_ids.append(boe_move_line.id)
    Severity: Major
    Found in l10n_it_bill_of_entry/account_invoice.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if line.advance_customs_vat:
                            advance_customs_vat_line = True
                            break
                if not advance_customs_vat_line:
      Severity: Major
      Found in l10n_it_bill_of_entry/account_invoice.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if boe_line.invoice_line_tax_id:
                            if len(boe_line.invoice_line_tax_id) > 1:
                                raise osv.except_osv(_('Error'),
                                    _("Can't handle more than 1 tax for line %s") % boe_line.name)
                            tax_code_id = (boe_line.invoice_line_tax_id[0].base_code_id
        Severity: Major
        Found in l10n_it_bill_of_entry/account_invoice.py - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                      for boe_move_line in bill_of_entry.move_id.line_id:
                                if boe_move_line.account_id.id == bill_of_entry.account_id.id:
                                    reconcile_ids.append(boe_move_line.id)
          Severity: Major
          Found in l10n_it_bill_of_entry/account_invoice.py and 1 other location - About 1 hr to fix
          l10n_it_ricevute_bancarie/wizard/wizard_unsolved.py on lines 206..211

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 39.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status