Sign upLogin

OmarElGabry/miniPHP

View on GitHub
Star
app/core/App.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function run(){

        // split the requested URL
        $this->splitUrl();
Severity: Minor
Found in app/core/App.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return $this->invoke("LoginController", $this->method, $this->args);
Severity: Major
Found in app/core/App.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return $this->invoke($controllerName, $this->method, $this->args);
    Severity: Major
    Found in app/core/App.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return $this->notFound();
      Severity: Major
      Found in app/core/App.php - About 30 mins to fix

        Function isControllerValid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function isControllerValid($controller){

        if(!empty($controller)){
            if (!preg_match('/\A[a-z]+\z/i', $controller) ||
                strtolower($controller) === "errorscontroller" ||
        Severity: Minor
        Found in app/core/App.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function isMethodValid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function isMethodValid($controller, $method){

        if(!empty($method)){
            if (!preg_match('/\A[a-z]+\z/i', $method) ||
                !method_exists($controller, $method)  ||
        Severity: Minor
        Found in app/core/App.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status